question upgrade MDL-16094 fix up earlier mistakes in the text format upgrade.

There was a mistake in the text format upgrade in the question bank. The wrong conversions were performed, and the wrong arguments were passed to text_to_html in the conversions that were done.

Also, not all the calls to format_text had been updated to use the values in the new format columns.

I think this change fixes everything, but I have only had very limited time to test it. I am committing it anyway, because that seems to me to be the best way to maximise testing. I think that the new code is certainly better than the old code was.
This commit is contained in:
Tim Hunt
2010-11-11 17:32:25 +00:00
parent d39c651378
commit a9efae50e3
20 changed files with 161 additions and 132 deletions
+1 -1
View File
@@ -963,7 +963,7 @@ class default_questiontype {
$formatoptions = new stdClass;
$formatoptions->para = false;
$comment = format_text($state->manualcomment, FORMAT_HTML,
$comment = format_text($state->manualcomment, $state->manualcommentformat,
$formatoptions, $cmoptions->course);
$commentlink = '';