From a7d4cb676d0b3fee7863922f9a7bb12252fe3341 Mon Sep 17 00:00:00 2001
From: Dongsheng Cai <unoter@gmail.com>
Date: Tue, 29 Jun 2010 07:20:51 +0000
Subject: [PATCH] MDL-22980, move mod/data/field/*/icon.gif to
 mod/data/pix/field/*.gif

---
 mod/data/lib.php                                    |   6 ++++--
 .../checkbox/icon.gif => pix/field/checkbox.gif}    | Bin
 .../{field/date/icon.gif => pix/field/date.gif}     | Bin
 .../{field/file/icon.gif => pix/field/file.gif}     | Bin
 .../latlong/icon.gif => pix/field/latlong.gif}      | Bin
 .../{field/menu/icon.gif => pix/field/menu.gif}     | Bin
 .../multimenu/icon.gif => pix/field/multimenu.gif}  | Bin
 .../{field/number/icon.gif => pix/field/number.gif} | Bin
 .../picture/icon.gif => pix/field/picture.gif}      | Bin
 .../icon.gif => pix/field/radiobutton.gif}          | Bin
 .../{field/text/icon.gif => pix/field/text.gif}     | Bin
 .../textarea/icon.gif => pix/field/textarea.gif}    | Bin
 mod/data/{field/url/icon.gif => pix/field/url.gif}  | Bin
 13 files changed, 4 insertions(+), 2 deletions(-)
 rename mod/data/{field/checkbox/icon.gif => pix/field/checkbox.gif} (100%)
 rename mod/data/{field/date/icon.gif => pix/field/date.gif} (100%)
 rename mod/data/{field/file/icon.gif => pix/field/file.gif} (100%)
 rename mod/data/{field/latlong/icon.gif => pix/field/latlong.gif} (100%)
 mode change 100644 => 100755
 rename mod/data/{field/menu/icon.gif => pix/field/menu.gif} (100%)
 rename mod/data/{field/multimenu/icon.gif => pix/field/multimenu.gif} (100%)
 rename mod/data/{field/number/icon.gif => pix/field/number.gif} (100%)
 rename mod/data/{field/picture/icon.gif => pix/field/picture.gif} (100%)
 rename mod/data/{field/radiobutton/icon.gif => pix/field/radiobutton.gif} (100%)
 rename mod/data/{field/text/icon.gif => pix/field/text.gif} (100%)
 rename mod/data/{field/textarea/icon.gif => pix/field/textarea.gif} (100%)
 rename mod/data/{field/url/icon.gif => pix/field/url.gif} (100%)

diff --git a/mod/data/lib.php b/mod/data/lib.php
index efd8adf33e9..41c1e03fcc9 100755
--- a/mod/data/lib.php
+++ b/mod/data/lib.php
@@ -429,8 +429,10 @@ class data_field_base {     // Base class for Database Field Types (see field/*/
     function image() {
         global $OUTPUT;
 
-        $str = '<a href="field.php?d='.$this->data->id.'&amp;fid='.$this->field->id.'&amp;mode=display&amp;sesskey='.sesskey().'">';
-        $str .= '<img src="'.$OUTPUT->pix_url('/field/' . $this->type . '/icon', 'data') . '" ';
+        $params = array('d'=>$this->data->id, 'fid'=>$this->field->id, 'mode'=>'display', 'sesskey'=>sesskey());
+        $link = new moodle_url('/mod/data/field.php', $params);
+        $str = '<a href="'.$link->out().'">';
+        $str .= '<img src="'.$OUTPUT->pix_url('field/'.$this->type, 'data') . '" ';
         $str .= 'height="'.$this->iconheight.'" width="'.$this->iconwidth.'" alt="'.$this->type.'" title="'.$this->type.'" /></a>';
         return $str;
     }
diff --git a/mod/data/field/checkbox/icon.gif b/mod/data/pix/field/checkbox.gif
similarity index 100%
rename from mod/data/field/checkbox/icon.gif
rename to mod/data/pix/field/checkbox.gif
diff --git a/mod/data/field/date/icon.gif b/mod/data/pix/field/date.gif
similarity index 100%
rename from mod/data/field/date/icon.gif
rename to mod/data/pix/field/date.gif
diff --git a/mod/data/field/file/icon.gif b/mod/data/pix/field/file.gif
similarity index 100%
rename from mod/data/field/file/icon.gif
rename to mod/data/pix/field/file.gif
diff --git a/mod/data/field/latlong/icon.gif b/mod/data/pix/field/latlong.gif
old mode 100644
new mode 100755
similarity index 100%
rename from mod/data/field/latlong/icon.gif
rename to mod/data/pix/field/latlong.gif
diff --git a/mod/data/field/menu/icon.gif b/mod/data/pix/field/menu.gif
similarity index 100%
rename from mod/data/field/menu/icon.gif
rename to mod/data/pix/field/menu.gif
diff --git a/mod/data/field/multimenu/icon.gif b/mod/data/pix/field/multimenu.gif
similarity index 100%
rename from mod/data/field/multimenu/icon.gif
rename to mod/data/pix/field/multimenu.gif
diff --git a/mod/data/field/number/icon.gif b/mod/data/pix/field/number.gif
similarity index 100%
rename from mod/data/field/number/icon.gif
rename to mod/data/pix/field/number.gif
diff --git a/mod/data/field/picture/icon.gif b/mod/data/pix/field/picture.gif
similarity index 100%
rename from mod/data/field/picture/icon.gif
rename to mod/data/pix/field/picture.gif
diff --git a/mod/data/field/radiobutton/icon.gif b/mod/data/pix/field/radiobutton.gif
similarity index 100%
rename from mod/data/field/radiobutton/icon.gif
rename to mod/data/pix/field/radiobutton.gif
diff --git a/mod/data/field/text/icon.gif b/mod/data/pix/field/text.gif
similarity index 100%
rename from mod/data/field/text/icon.gif
rename to mod/data/pix/field/text.gif
diff --git a/mod/data/field/textarea/icon.gif b/mod/data/pix/field/textarea.gif
similarity index 100%
rename from mod/data/field/textarea/icon.gif
rename to mod/data/pix/field/textarea.gif
diff --git a/mod/data/field/url/icon.gif b/mod/data/pix/field/url.gif
similarity index 100%
rename from mod/data/field/url/icon.gif
rename to mod/data/pix/field/url.gif