From a7a5f6626acce1c507a4a4e64083f2d19d28686e Mon Sep 17 00:00:00 2001
From: Peter Dias <peter@moodle.com>
Date: Wed, 27 Oct 2021 10:14:51 +0800
Subject: [PATCH] MDL-72816 navigation: Make sure a secondary node is active

- Clone nodes shared between nav trees before utilising it.
---
 lib/classes/navigation/views/secondary.php | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/lib/classes/navigation/views/secondary.php b/lib/classes/navigation/views/secondary.php
index b933db44841..591a530c073 100644
--- a/lib/classes/navigation/views/secondary.php
+++ b/lib/classes/navigation/views/secondary.php
@@ -352,7 +352,7 @@ class secondary extends view {
                         $othernode = $this->get_first_action_for_node($other);
                         // Get the first node and check whether it's been added already.
                         if ($othernode && !$this->get($othernode->key)) {
-                            $this->add_node($othernode);
+                            $this->add_node(clone $othernode);
                         }
                     }
                 }
@@ -481,9 +481,9 @@ class secondary extends view {
                     } else {
                         $child->action = new \moodle_url("/admin/search.php", [], "link$child->key");
                     }
-                    $this->add_node($child);
+                    $this->add_node(clone $child);
                 } else {
-                    $siteadminnode->add_node($child);
+                    $siteadminnode->add_node(clone $child);
                 }
             }
         }
@@ -502,10 +502,10 @@ class secondary extends view {
             if (is_string($key)) {
                 $parentnode = $nodes[floor($key)] ?? null;
                 if ($parentnode) {
-                    $parentnode->add_node($node);
+                    $parentnode->add_node(clone $node);
                 }
             } else {
-                $this->add_node($node);
+                $this->add_node(clone $node);
             }
         }
     }
@@ -534,7 +534,7 @@ class secondary extends view {
 
                 // Confirm we have a valid object to add.
                 if ($leftovernode) {
-                    $this->add_node($leftovernode);
+                    $this->add_node(clone $leftovernode);
                 }
             }
         }