From 7721ddb679096ee6076a77629a92329569787721 Mon Sep 17 00:00:00 2001 From: Ilya Tregubov Date: Fri, 26 Apr 2024 10:54:05 +0800 Subject: [PATCH] MDL-78889 gradereport_user: Fix pass/fail icon for totals When the category has a 'grade to pass' set, the pass/fail icon was displayed even when the category total grade values was hidden. --- grade/report/user/classes/report/user.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/grade/report/user/classes/report/user.php b/grade/report/user/classes/report/user.php index 8ed200e854b..c9cfc11682f 100644 --- a/grade/report/user/classes/report/user.php +++ b/grade/report/user/classes/report/user.php @@ -713,7 +713,7 @@ class user extends grade_report { $gradestatusclass = ''; $gradepassicon = ''; $ispassinggrade = $gradegrade->is_passed($gradegrade->grade_item); - if (!is_null($ispassinggrade)) { + if (!is_null($gradeval) && !is_null($ispassinggrade)) { $gradestatusclass = $ispassinggrade ? 'gradepass' : 'gradefail'; if ($ispassinggrade) { $gradepassicon = $OUTPUT->pix_icon(