From a724ceb99f517a1cb36ab1f5bc20aa755486e9c2 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Fri, 31 Oct 2014 00:55:04 -0700 Subject: [PATCH] MDL-47919 tool_monitor: only use set_label() on valid object --- admin/tool/monitor/classes/output/managesubs/rules.php | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/admin/tool/monitor/classes/output/managesubs/rules.php b/admin/tool/monitor/classes/output/managesubs/rules.php index 62182ccf8b6..6821583e6e2 100644 --- a/admin/tool/monitor/classes/output/managesubs/rules.php +++ b/admin/tool/monitor/classes/output/managesubs/rules.php @@ -128,9 +128,15 @@ class rules extends \table_sql implements \renderable { */ public function col_select(\tool_monitor\rule $rule) { global $OUTPUT; + $select = $rule->get_module_select($this->courseid); - $select->set_label(get_string('subscribeto', 'tool_monitor', $rule->get_name($this->context)), array('class' => 'accesshide')); - return is_object($select) ? $OUTPUT->render($select) : $select; + + if ($select instanceof \single_select) { + $select->set_label(get_string('subscribeto', 'tool_monitor', $rule->get_name($this->context)), array('class' => 'accesshide')); + return $OUTPUT->render($select); + } else { + return $select; + } } /**