From 1e988d262bd8383d8519863dd774e65bb59dc253 Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Thu, 4 Apr 2013 11:45:11 +0800 Subject: [PATCH 1/4] MDL-38741 qtype_calculate: fix missing setType --- question/type/calculated/edit_calculated_form.php | 1 + 1 file changed, 1 insertion(+) diff --git a/question/type/calculated/edit_calculated_form.php b/question/type/calculated/edit_calculated_form.php index a7af2824803..d3bcc079bc1 100644 --- a/question/type/calculated/edit_calculated_form.php +++ b/question/type/calculated/edit_calculated_form.php @@ -108,6 +108,7 @@ class qtype_calculated_edit_form extends qtype_numerical_edit_form { $mform->addElement('hidden', 'initialcategory', 1); $mform->addElement('hidden', 'reload', 1); $mform->setType('initialcategory', PARAM_INT); + $mform->setType('reload', PARAM_BOOL); $html2 = $this->qtypeobj->print_dataset_definitions_category($this->question); $mform->insertElementBefore( $mform->createElement('static', 'listcategory', $label, $html2), 'name'); From dfd89b0bb9446486134c68d16558768a6ff8fbbb Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Thu, 4 Apr 2013 11:49:05 +0800 Subject: [PATCH 2/4] MDL-38741 qtype_calculatedmulti: fix missing setType --- question/type/calculatedmulti/edit_calculatedmulti_form.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/question/type/calculatedmulti/edit_calculatedmulti_form.php b/question/type/calculatedmulti/edit_calculatedmulti_form.php index a5156074ec0..b64de2affed 100644 --- a/question/type/calculatedmulti/edit_calculatedmulti_form.php +++ b/question/type/calculatedmulti/edit_calculatedmulti_form.php @@ -84,6 +84,7 @@ class qtype_calculatedmulti_edit_form extends question_edit_form { $addrepeated[] = $mform->createElement('hidden', 'tolerancetype', 1); $repeatedoptions['tolerance']['type'] = PARAM_FLOAT; $repeatedoptions['tolerance']['default'] = 0.01; + $repeatedoptions['tolerancetype']['type'] = PARAM_INT; $addrepeated[] = $mform->createElement('select', 'correctanswerlength', get_string('correctanswershows', 'qtype_calculated'), range(0, 9)); @@ -107,6 +108,7 @@ class qtype_calculatedmulti_edit_form extends question_edit_form { $mform->addElement('hidden', 'initialcategory', 1); $mform->addElement('hidden', 'reload', 1); $mform->setType('initialcategory', PARAM_INT); + $mform->setType('reload', PARAM_BOOL); $html2 = ''; $mform->insertElementBefore( From ce5bb3a91263302f48f8a6d5fd34b364b4113634 Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Thu, 4 Apr 2013 11:57:46 +0800 Subject: [PATCH 3/4] MDL-38741 qtype_calculatesimple: missing setType call --- question/type/calculatedsimple/edit_calculatedsimple_form.php | 1 + 1 file changed, 1 insertion(+) diff --git a/question/type/calculatedsimple/edit_calculatedsimple_form.php b/question/type/calculatedsimple/edit_calculatedsimple_form.php index e12a7119c20..cd2f9e58f2a 100644 --- a/question/type/calculatedsimple/edit_calculatedsimple_form.php +++ b/question/type/calculatedsimple/edit_calculatedsimple_form.php @@ -292,6 +292,7 @@ class qtype_calculatedsimple_edit_form extends qtype_calculated_edit_form { $label = get_string("sharedwildcards", "qtype_calculated"); $mform->addElement('hidden', 'synchronize', 0); $mform->addElement('hidden', 'initialcategory', 1); + $mform->setType('synchronize', PARAM_BOOL); $mform->setType('initialcategory', PARAM_INT); $mform->addElement('hidden', 'reload', 1); $mform->setType('reload', PARAM_INT); From 8971ddd5a9c6fbfaf9b7c9e9579ddcaa40ce1201 Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Thu, 4 Apr 2013 11:59:35 +0800 Subject: [PATCH 4/4] MDL-38741 qtype_truefalse: fix missing setType call --- question/type/truefalse/edit_truefalse_form.php | 1 + 1 file changed, 1 insertion(+) diff --git a/question/type/truefalse/edit_truefalse_form.php b/question/type/truefalse/edit_truefalse_form.php index 9e6f930362f..3af90343faf 100644 --- a/question/type/truefalse/edit_truefalse_form.php +++ b/question/type/truefalse/edit_truefalse_form.php @@ -60,6 +60,7 @@ class qtype_truefalse_edit_form extends question_edit_form { get_string('settingsformultipletries', 'question')); $mform->addElement('hidden', 'penalty', 1); + $mform->setType('penalty', PARAM_FLOAT); $mform->addElement('static', 'penaltymessage', get_string('penaltyforeachincorrecttry', 'question'), 1);