From a4f657d8467f69f9082e7f78809dec7e50207d71 Mon Sep 17 00:00:00 2001 From: Mikhail Golenkov Date: Wed, 18 Aug 2021 11:01:29 +1000 Subject: [PATCH] MDL-72239 phpunit: Assert the number of db queries to be less or equal The course unit test assumes the number of db call. This assumption is correct in vanilla moodle only. Once some plugins installed their observers may do extra db calls. Due to caching the number of actual db calls in the unit test may be fewer. --- course/tests/courselib_test.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/course/tests/courselib_test.php b/course/tests/courselib_test.php index c9975026a75..860589a3ab8 100644 --- a/course/tests/courselib_test.php +++ b/course/tests/courselib_test.php @@ -4676,7 +4676,7 @@ class core_course_courselib_testcase extends advanced_testcase { sort($expectedresult); $this->assertEquals($expectedresult, $actualresult); - $this->assertEquals($expecteddbqueries, $DB->perf_get_queries() - $initialquerycount); + $this->assertLessThanOrEqual($expecteddbqueries, $DB->perf_get_queries() - $initialquerycount); } /**