L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-76784 core_cache: versioned cache (modinfo) can fail in install

Browse Source 
When cache is disabled but temporary in-memory caches are allowed,
these were direct instances of cachestore_static with no loader, which
meant that the get_versioned and set_versioned functions did not work.
This commit is contained in:
sam marshall
2023-02-21 10:40:23 +00:00
parent 8503f2cfd8
commit a3b1e3b4ee
2 changed files with 41 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cache/disabledlib.php
Vendored
+7 -2
View File
@@ -294,8 +294,13 @@ class cache_factory_disabled extends cache_factory {
$definition = $this->create_definition($component, $area);
// The cachestore_static class returns true to all three 'SUPPORTS_' checks so it
// can be used with all definitions.
$cache = new cachestore_static('TEMP:' . $component . '/' . $area);
$cache->initialise($definition);
$store = new cachestore_static('TEMP:' . $component . '/' . $area);
$store->initialise($definition);
// We need to use a cache loader wrapper rather than directly returning the store,
// or it wouldn't have support for versioning. The cache_application class is used
// (rather than cache_request which might make more sense logically) because it
// includes support for locking, which might be necessary for some caches.
$cache = new cache_application($definition, $store);
self::$tempcaches[$key] = $cache;
}
return $cache;