From a33c0e30eb622b86d53af122f9b22ba9602d8e89 Mon Sep 17 00:00:00 2001
From: Juan Leyva <juanleyvadelgado@gmail.com>
Date: Thu, 30 Mar 2017 16:23:39 +0200
Subject: [PATCH] MDL-58415 mod_lesson: Return always allowofflineattempts

We need this field always to be able to display if the lesson is
available or not for download
---
 mod/lesson/classes/external.php                         | 2 +-
 mod/lesson/classes/external/lesson_summary_exporter.php | 1 -
 mod/lesson/tests/external_test.php                      | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/mod/lesson/classes/external.php b/mod/lesson/classes/external.php
index 98afaa08c5c..cca45a4f14e 100644
--- a/mod/lesson/classes/external.php
+++ b/mod/lesson/classes/external.php
@@ -65,7 +65,7 @@ class mod_lesson_external extends external_api {
                 'maxanswers', 'maxattempts', 'review', 'nextpagedefault', 'feedback', 'minquestions',
                 'maxpages', 'timelimit', 'retake', 'mediafile', 'mediaheight', 'mediawidth',
                 'mediaclose', 'slideshow', 'width', 'height', 'bgcolor', 'displayleft', 'displayleftif',
-                'progressbar', 'allowofflineattempts');
+                'progressbar');
 
             foreach ($fields as $field) {
                 unset($lessonrecord->{$field});
diff --git a/mod/lesson/classes/external/lesson_summary_exporter.php b/mod/lesson/classes/external/lesson_summary_exporter.php
index 0e9a9cb6e3f..fb262be14db 100644
--- a/mod/lesson/classes/external/lesson_summary_exporter.php
+++ b/mod/lesson/classes/external/lesson_summary_exporter.php
@@ -249,7 +249,6 @@ class lesson_summary_exporter extends exporter {
             'allowofflineattempts' => array(
                 'type' => PARAM_BOOL,
                 'description' => 'Whether to allow the lesson to be attempted offline in the mobile app',
-                'optional' => true,
             ),
         );
     }
diff --git a/mod/lesson/tests/external_test.php b/mod/lesson/tests/external_test.php
index 56fc8522f24..f747614b212 100644
--- a/mod/lesson/tests/external_test.php
+++ b/mod/lesson/tests/external_test.php
@@ -1304,7 +1304,7 @@ class mod_lesson_external_testcase extends externallib_advanced_testcase {
         // Lesson not using password.
         $result = mod_lesson_external::get_lesson($this->lesson->id);
         $result = external_api::clean_returnvalue(mod_lesson_external::get_lesson_returns(), $result);
-        $this->assertCount(5, $result['lesson']);   // Expect just this few fields.
+        $this->assertCount(6, $result['lesson']);   // Expect just this few fields.
         $this->assertFalse(isset($result['intro']));
     }