diff --git a/course/classes/output/bulk_activity_completion_renderer.php b/course/classes/output/bulk_activity_completion_renderer.php index e6ea0a3f965..f923baa333f 100644 --- a/course/classes/output/bulk_activity_completion_renderer.php +++ b/course/classes/output/bulk_activity_completion_renderer.php @@ -126,8 +126,12 @@ class core_course_bulk_activity_completion_renderer extends plugin_renderer_base * @param moodleform $form * @param array $modules * @return string + * @deprecated since Moodle 4.3 MDL-78528 + * @todo MDL-78711 This will be deleted in Moodle 4.7 */ public function edit_default_completion($form, $modules) { + debugging('edit_default_completion() is deprecated and will be removed.', DEBUG_DEVELOPER); + ob_start(); $form->display(); $formhtml = ob_get_contents(); diff --git a/course/editdefaultcompletion.php b/course/editdefaultcompletion.php deleted file mode 100644 index 9a73f39ad83..00000000000 --- a/course/editdefaultcompletion.php +++ /dev/null @@ -1,74 +0,0 @@ -. - -/** - * Bulk activity completion selection - * - * @package core_completion - * @copyright 2017 Marina Glancy - * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later - */ - -require_once(__DIR__ . "/../config.php"); -require_once($CFG->libdir . '/completionlib.php'); - -$courseid = required_param('id', PARAM_INT); -$modids = optional_param_array('modids', [], PARAM_INT); -$course = get_course($courseid); -require_login($course); - -navigation_node::override_active_url(new moodle_url('/course/completion.php', array('id' => $course->id))); -$PAGE->set_url(new moodle_url('/course/editdefaultcompletion.php', ['id' => $courseid])); -$PAGE->set_title($course->shortname); -$PAGE->set_heading($course->fullname); -$PAGE->set_pagelayout('admin'); - -require_capability('moodle/course:manageactivities', context_course::instance($course->id)); - -// Prepare list of selected modules. -$manager = new \core_completion\manager($course->id); -$allmodules = $manager->get_activities_and_resources(); -$modules = []; -foreach ($allmodules->modules as $module) { - if ($module->canmanage && in_array($module->id, $modids)) { - $modules[$module->id] = $module; - } -} - -$returnurl = new moodle_url('/course/defaultcompletion.php', ['id' => $course->id]); -if (empty($modules)) { - redirect($returnurl); -} - -$form = new core_completion_defaultedit_form(null, ['course' => $course, 'modules' => $modules]); - -if ($form->is_cancelled()) { - redirect($returnurl); -} else if ($data = $form->get_data()) { - $manager->apply_default_completion($data, $form->has_custom_completion_rules()); - redirect($returnurl); -} - -$renderer = $PAGE->get_renderer('core_course', 'bulk_activity_completion'); - -echo $OUTPUT->header(); - -echo $OUTPUT->heading(get_string('defaultcompletion', 'completion')); - -echo $renderer->edit_default_completion($form, $modules); - -echo $OUTPUT->footer(); - diff --git a/course/upgrade.txt b/course/upgrade.txt index 5300481c74f..72e6adb8218 100644 --- a/course/upgrade.txt +++ b/course/upgrade.txt @@ -6,6 +6,7 @@ information provided here is intended especially for developers. * External function core_course_external::get_course_contents() now returns a new field activitybadge with the data to display the activity badge when the module implements it. * prepare_new_moduleinfo_data() now accepts a parameter "suffix" that will be added to the name of the completion rules. +* The method core_course_bulk_activity_completion_renderer:: edit_default_completion() has been deprecated and will be removed. === 4.2 === * course/mod.php now accepts parameter beforemod for adding course modules. It contains the course module id