From 76e4c52a2f65d28a2811293f030056a52d763c95 Mon Sep 17 00:00:00 2001 From: Tony Butler Date: Wed, 21 Sep 2016 14:49:30 +0100 Subject: [PATCH] MDL-56062 mod_assign: Use $gradeitem->get_decimals() for grade display --- mod/assign/feedback/offline/importgradesform.php | 3 ++- mod/assign/gradingtable.php | 6 ++++-- mod/assign/locallib.php | 11 ++++++----- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/mod/assign/feedback/offline/importgradesform.php b/mod/assign/feedback/offline/importgradesform.php index a81b20790fe..32652073fda 100644 --- a/mod/assign/feedback/offline/importgradesform.php +++ b/mod/assign/feedback/offline/importgradesform.php @@ -134,7 +134,8 @@ class assignfeedback_offline_import_grades_form extends moodleform implements re if (!empty($scaleoptions)) { $formattedgrade = $scaleoptions[$grade]; } else { - $formattedgrade = format_float($grade, 2); + $gradeitem = $assignment->get_grade_item(); + $formattedgrade = format_float($grade, $gradeitem->get_decimals()); } $updates[] = get_string('gradeupdate', 'assignfeedback_offline', array('grade'=>$formattedgrade, 'student'=>$userdesc)); diff --git a/mod/assign/gradingtable.php b/mod/assign/gradingtable.php index 85b02d98f90..867ac14c1c5 100644 --- a/mod/assign/gradingtable.php +++ b/mod/assign/gradingtable.php @@ -628,7 +628,8 @@ class assign_grading_table extends table_sql implements renderable { if ($grade == -1 || $grade === null) { return ''; } - return format_float($grade, 2); + $gradeitem = $this->assignment->get_grade_item(); + return format_float($grade, $gradeitem->get_decimals()); } else { // This is a custom scale. $scale = $this->assignment->display_grade($grade, false); @@ -825,7 +826,8 @@ class assign_grading_table extends table_sql implements renderable { * @return string */ public function col_grademax(stdClass $row) { - return format_float($this->assignment->get_instance()->grade, 2); + $gradeitem = $this->assignment->get_grade_item(); + return format_float($this->assignment->get_instance()->grade, $gradeitem->get_decimals()); } /** diff --git a/mod/assign/locallib.php b/mod/assign/locallib.php index 472d8eab3c0..d0f1b960644 100644 --- a/mod/assign/locallib.php +++ b/mod/assign/locallib.php @@ -1371,6 +1371,7 @@ class assign { static $scalegrades = array(); + $decimals = $this->get_grade_item()->get_decimals(); $o = ''; if ($this->get_instance()->grade >= 0) { @@ -1379,7 +1380,7 @@ class assign { if ($grade < 0) { $displaygrade = ''; } else { - $displaygrade = format_float($grade, 2); + $displaygrade = format_float($grade, $decimals); } $o .= '