From dbd8cadb5cb24652182a16d51a97644b2eb0b095 Mon Sep 17 00:00:00 2001 From: Eugene Venter Date: Tue, 1 Nov 2016 10:10:21 +1300 Subject: [PATCH] MDL-52216 mod_lesson: prevent invalid view modes --- mod/lesson/edit.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mod/lesson/edit.php b/mod/lesson/edit.php index 2bcae9e937c..e337fe81cf2 100644 --- a/mod/lesson/edit.php +++ b/mod/lesson/edit.php @@ -38,6 +38,10 @@ $context = context_module::instance($cm->id); require_capability('mod/lesson:manage', $context); $mode = optional_param('mode', get_user_preferences('lesson_view', 'collapsed'), PARAM_ALPHA); +// Ensure a valid mode is set. +if (!in_array($mode, array('single', 'full', 'collapsed'))) { + $mode = 'collapsed'; +} $PAGE->set_url('/mod/lesson/edit.php', array('id'=>$cm->id,'mode'=>$mode)); if ($mode != get_user_preferences('lesson_view', 'collapsed') && $mode !== 'single') {