L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-52651 htmlpurifier: Append rel=noreferrer to links.

Browse Source 
Thank you to Zachary Durber for originally working on this issue.
This commit is contained in:
Cameron Ball
2016-03-08 02:09:13 +01:00
committed by Eloy Lafuente (stronk7)
parent ea8987644f
commit 9f91c23536
4 changed files with 76 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/htmlpurifier_test.php
+5 -1
View File
@@ -40,9 +40,13 @@ class core_htmlpurifier_testcase extends basic_testcase {
* Verify _blank target is allowed.
*/
public function test_allow_blank_target() {
// See MDL-52651 for an explanation as to why the rel="noreferrer" attribute is expected here.
// Also note we do not need to test links with an existing rel attribute as the HTML Purifier is configured to remove
// the rel attribute.
$text = '<a href="http://moodle.org" target="_blank">Some link</a>';
$expected = '<a href="http://moodle.org" target="_blank" rel="noreferrer">Some link</a>';
$result = format_text($text, FORMAT_HTML);
$this->assertSame($text, $result);
$this->assertSame($expected, $result);
$result = format_text('<a href="http://moodle.org" target="some">Some link</a>', FORMAT_HTML);
$this->assertSame('<a href="http://moodle.org">Some link</a>', $result);