diff --git a/grade/edit/tree/lib.php b/grade/edit/tree/lib.php index 7fe400db8de..e97966395d1 100644 --- a/grade/edit/tree/lib.php +++ b/grade/edit/tree/lib.php @@ -300,11 +300,13 @@ class grade_edit_tree { $parentcategories = array_merge($rowclasses, [$eid]); $emptyrow->attributes['class'] = 'spacer ' . implode(' ', $parentcategories); $emptyrow->attributes['data-hidden'] = 'false'; + $emptyrow->attributes['aria-hidden'] = 'true'; $headercell = new html_table_cell(); $headercell->header = true; $headercell->scope = 'row'; $headercell->attributes['class'] = 'cell column-rowspan rowspan'; + $headercell->attributes['aria-hidden'] = 'true'; $headercell->rowspan = $row_count; $emptyrow->cells[] = $headercell; @@ -314,6 +316,7 @@ class grade_edit_tree { $endcell = new html_table_cell(); $endcell->colspan = (19 - $level); $endcell->attributes['class'] = 'emptyrow colspan ' . $levelclass; + $endcell->attributes['aria-hidden'] = 'true'; $returnrows[] = new html_table_row(array($endcell)); @@ -744,13 +747,11 @@ abstract class grade_edit_tree_column { public function get_category_cell($category, $levelclass, $params) { $cell = clone($this->categorycell); $cell->attributes['class'] .= ' ' . $levelclass; - $cell->attributes['text'] = ''; return $cell; } public function get_item_cell($item, $params) { $cell = clone($this->itemcell); - $cell->attributes['text'] = ''; if (isset($params['level'])) { $level = $params['level'] + (($item->itemtype == 'category' || $item->itemtype == 'course') ? 0 : 1); $cell->attributes['class'] .= ' level' . $level; @@ -1121,7 +1122,7 @@ class grade_edit_tree_column_select extends grade_edit_tree_column { } // Build the master checkbox. $mastercheckbox = new \core\output\checkbox_toggleall($togglegroup, true, [ - 'id' => $togglegroup, + 'id' => 'select_category_' . $category->id, 'name' => $togglegroup, 'value' => 1, 'classes' => 'itemselect ignoredirty', diff --git a/grade/lib.php b/grade/lib.php index 2a73cd30fdb..a274d6dd0c3 100644 --- a/grade/lib.php +++ b/grade/lib.php @@ -970,15 +970,13 @@ function print_grade_page_head(int $courseid, string $active_type, ?string $acti $output = ''; // Add a help dialogue box if provided. - if (isset($headerhelpidentifier)) { + if (isset($headerhelpidentifier) && !empty($heading)) { $output = $OUTPUT->heading_with_help($heading, $headerhelpidentifier, $headerhelpcomponent); - } else { - if (isset($user)) { - $renderer = $PAGE->get_renderer('core_grades'); - $output = $OUTPUT->heading($renderer->user_heading($user, $courseid)); - } else { - $output = $OUTPUT->heading($heading); - } + } else if (isset($user)) { + $renderer = $PAGE->get_renderer('core_grades'); + $output = $OUTPUT->heading($renderer->user_heading($user, $courseid)); + } else if (!empty($heading)) { + $output = $OUTPUT->heading($heading); } if ($return) { diff --git a/lib/templates/moremenu_children.mustache b/lib/templates/moremenu_children.mustache index bed6e9d8cd9..cc7d5b56673 100644 --- a/lib/templates/moremenu_children.mustache +++ b/lib/templates/moremenu_children.mustache @@ -43,7 +43,7 @@ {{#children}} {{^divider}} {{#is_action_link}} - {{{text}}} @@ -86,7 +86,7 @@ {{/istablist}} {{^istablist}} {{#is_action_link}} - + {{{text}}} {{#action_link_actions}}