diff --git a/lib/dml/tests/dml_test.php b/lib/dml/tests/dml_test.php index 39481ad67cd..f696104c9ad 100644 --- a/lib/dml/tests/dml_test.php +++ b/lib/dml/tests/dml_test.php @@ -1797,7 +1797,7 @@ class dml_testcase extends database_driver_testcase { $this->assertSame(false, $DB->get_field($tablename, 'course', array('course' => 11), IGNORE_MISSING)); try { $DB->get_field($tablename, 'course', array('course' => 4), MUST_EXIST); - $this->assertFail('Exception expected due to missing record'); + $this->fail('Exception expected due to missing record'); } catch (dml_exception $ex) { $this->assertTrue(true); } @@ -1952,7 +1952,7 @@ class dml_testcase extends database_driver_testcase { // custom sequence - missing id error try { $DB->insert_record_raw($tablename, array('course' => 3, 'onechar' => 'bb'), true, false, true); - $this->assertFail('Exception expected due to missing record'); + $this->fail('Exception expected due to missing record'); } catch (coding_exception $ex) { $this->assertTrue(true); } @@ -1960,7 +1960,7 @@ class dml_testcase extends database_driver_testcase { // wrong column error try { $DB->insert_record_raw($tablename, array('xxxxx' => 3, 'onechar' => 'bb')); - $this->assertFail('Exception expected due to invalid column'); + $this->fail('Exception expected due to invalid column'); } catch (dml_exception $ex) { $this->assertTrue(true); } diff --git a/lib/tests/moodlelib_test.php b/lib/tests/moodlelib_test.php index f5045c3476f..fef75b5f895 100644 --- a/lib/tests/moodlelib_test.php +++ b/lib/tests/moodlelib_test.php @@ -1405,46 +1405,46 @@ class moodlelib_testcase extends advanced_testcase { $longvalue = str_repeat('a', 1334); try { set_user_preference('_test_long_user_preference', $longvalue); - $this->assertFail('Exception expected - longer than 1333 chars not allowed as preference value'); - } catch (Exception $e) { - $this->assertTrue($e instanceof coding_exception); + $this->fail('Exception expected - longer than 1333 chars not allowed as preference value'); + } catch (coding_exception $ex) { + $this->assertTrue(true); } //test invalid params try { set_user_preference('_test_user_preferences_pref', array()); - $this->assertFail('Exception expected - array not valid preference value'); - } catch (Exception $ex) { + $this->fail('Exception expected - array not valid preference value'); + } catch (coding_exception $ex) { $this->assertTrue(true); } try { set_user_preference('_test_user_preferences_pref', new stdClass); - $this->assertFail('Exception expected - class not valid preference value'); - } catch (Exception $ex) { + $this->fail('Exception expected - class not valid preference value'); + } catch (coding_exception $ex) { $this->assertTrue(true); } try { - set_user_preference('_test_user_preferences_pref', 1, array('xx'=>1)); - $this->assertFail('Exception expected - user instance expected'); - } catch (Exception $ex) { + set_user_preference('_test_user_preferences_pref', 1, array('xx' => 1)); + $this->fail('Exception expected - user instance expected'); + } catch (coding_exception $ex) { $this->assertTrue(true); } try { set_user_preference('_test_user_preferences_pref', 1, 'abc'); - $this->assertFail('Exception expected - user instance expected'); - } catch (Exception $ex) { + $this->fail('Exception expected - user instance expected'); + } catch (coding_exception $ex) { $this->assertTrue(true); } try { set_user_preference('', 1); - $this->assertFail('Exception expected - invalid name accepted'); - } catch (Exception $ex) { + $this->fail('Exception expected - invalid name accepted'); + } catch (coding_exception $ex) { $this->assertTrue(true); } try { set_user_preference('1', 1); - $this->assertFail('Exception expected - invalid name accepted'); - } catch (Exception $ex) { + $this->fail('Exception expected - invalid name accepted'); + } catch (coding_exception $ex) { $this->assertTrue(true); }