MDL-57273 core: Remove magic setters and getters

Remove the magic getters and setters from persistent. They are deprecated only in the persistent class for competencies.
2017-01-20 12:56:19 +08:00
parent 32896dcbab
commit 9c91a9593d
120 changed files with 2868 additions and 2823 deletions
@@ -44,4 +44,23 @@ class_alias('core\\invalid_persistent_exception', 'core_competency\\invalid_pers
 * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
 */
 abstract class persistent extends \core\persistent {
+    /**
+     * Magic method to capture getters and setters.
+     * This is only available for competency persistents for backwards compatibility.
+     * It is recommended to use get('propertyname') and set('propertyname', 'value') directly.
+     *
+     * @param  string $method Callee.
+     * @param  array $arguments List of arguments.
+     * @return mixed
+     */
+    final public function __call($method, $arguments) {
+        debugging('Use of magic setters and getters is deprecated. Use get() and set().', DEBUG_DEVELOPER);
+        if (strpos($method, 'get_') === 0) {
+            return $this->get(substr($method, 4));
+        } else if (strpos($method, 'set_') === 0) {
+            return $this->set(substr($method, 4), $arguments[0]);
+        }
+        throw new coding_exception('Unexpected method call: ' . $method);
+    }
+
 }