L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-29804 - Clean up Feedback modules coding style

Browse Source
This commit is contained in:
Andreas Grabs
2011-10-28 00:30:42 +02:00
parent 38e9a1cc79
commit 9c5bc7a580
67 changed files with 5875 additions and 4087 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/feedback/analysis.php
+46 -29
View File
@@ -1,4 +1,18 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* shows an analysed view of feedback
@@ -11,7 +25,6 @@
require_once("../../config.php");
require_once("lib.php");
// $SESSION->feedback->current_tab = 'analysis';
$current_tab = 'analysis';
$id = required_param('id', PARAM_INT); //the POST dominated the GET
@@ -39,23 +52,23 @@ if (!$context = get_context_instance(CONTEXT_MODULE, $cm->id)) {
print_error('badcontext');
}
if($course->id == SITEID) {
if ($course->id == SITEID) {
require_login($course->id, true);
}else{
} else {
require_login($course->id, true, $cm);
}
//check whether the given courseid exists
if($courseid AND $courseid != SITEID) {
if($course2 = $DB->get_record('course', array('id'=>$courseid))){
if ($courseid AND $courseid != SITEID) {
if ($course2 = $DB->get_record('course', array('id'=>$courseid))) {
require_course_login($course2); //this overwrites the object $course :-(
$course = $DB->get_record("course", array("id"=>$cm->course)); // the workaround
}else {
} else {
print_error('invalidcourseid');
}
}
if( !( ((intval($feedback->publish_stats) == 1) AND
if ( !( ((intval($feedback->publish_stats) == 1) AND
has_capability('mod/feedback:viewanalysepage', $context)) OR
has_capability('mod/feedback:viewreports', $context))) {
print_error('error');
@@ -65,30 +78,29 @@ if( !( ((intval($feedback->publish_stats) == 1) AND
$strfeedbacks = get_string("modulenameplural", "feedback");
$strfeedback = get_string("modulename", "feedback");
$PAGE->navbar->add(get_string('analysis','feedback'));
$PAGE->navbar->add(get_string('analysis', 'feedback'));
$PAGE->set_heading(format_string($course->fullname));
$PAGE->set_title(format_string($feedback->name));
echo $OUTPUT->header();
/// print the tabs
include('tabs.php');
require('tabs.php');
//print analysed items
echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthwide');
//get the groupid
$groupselect = groups_print_activity_menu($cm, $CFG->wwwroot . '/mod/feedback/analysis.php?id=' . $cm->id.'&do_show=analysis', true);
$myurl = $CFG->wwwroot.'/mod/feedback/analysis.php?id='.$cm->id.'&do_show=analysis';
$groupselect = groups_print_activity_menu($cm, $myurl, true);
$mygroupid = groups_get_activity_group($cm);
if( has_capability('mod/feedback:viewreports', $context) ) {
if ( has_capability('mod/feedback:viewreports', $context) ) {
echo isset($groupselect) ? $groupselect : '';
echo '<div class="clearer"></div>';
//button "export to excel"
//echo '<div class="mdl-align">';
// echo '<div class="feedback_centered_button">';
echo $OUTPUT->container_start('form-buttons');
$aurl = new moodle_url('analysis_to_excel.php', array('sesskey'=>sesskey(), 'id'=>$id));
echo $OUTPUT->single_button($aurl, get_string('export_to_excel', 'feedback'));
@@ -99,50 +111,55 @@ if( has_capability('mod/feedback:viewreports', $context) ) {
$completedscount = feedback_get_completeds_group_count($feedback, $mygroupid);
//show the group, if available
if($mygroupid and $group = $DB->get_record('groups', array('id'=>$mygroupid))) {
if ($mygroupid and $group = $DB->get_record('groups', array('id'=>$mygroupid))) {
echo '<b>'.get_string('group').': '.$group->name. '</b><br />';
}
//show the count
echo '<b>'.get_string('completed_feedbacks', 'feedback').': '.$completedscount. '</b><br />';
// get the items of the feedback
$items = $DB->get_records('feedback_item', array('feedback'=>$feedback->id, 'hasvalue'=>1), 'position');
$items = $DB->get_records('feedback_item',
array('feedback'=>$feedback->id, 'hasvalue'=>1),
'position');
//show the count
if(is_array($items)){
echo '<b>'.get_string('questions', 'feedback').': ' .sizeof($items). ' </b><hr />';
if (is_array($items)) {
echo '<b>'.get_string('questions', 'feedback').': ' .count($items). ' </b><hr />';
} else {
$items=array();
}
$check_anonymously = true;
if($mygroupid > 0 AND $feedback->anonymous == FEEDBACK_ANONYMOUS_YES) {
if($completedscount < FEEDBACK_MIN_ANONYMOUS_COUNT_IN_GROUP) {
if ($mygroupid > 0 AND $feedback->anonymous == FEEDBACK_ANONYMOUS_YES) {
if ($completedscount < FEEDBACK_MIN_ANONYMOUS_COUNT_IN_GROUP) {
$check_anonymously = false;
}
}
// echo '<div class="mdl-align"><table width="80%" cellpadding="10"><tr><td>';
echo '<div><table width="80%" cellpadding="10"><tr><td>';
if($check_anonymously) {
if ($check_anonymously) {
$itemnr = 0;
//print the items in an analysed form
foreach($items as $item) {
if($item->hasvalue == 0) continue;
foreach ($items as $item) {
if ($item->hasvalue == 0) {
continue;
}
echo '<table width="100%" class="generalbox">';
//get the class of item-typ
$itemobj = feedback_get_item_class($item->typ);
$itemnr++;
if($feedback->autonumbering) {
if ($feedback->autonumbering) {
$printnr = $itemnr.'.';
} else {
$printnr = '';
}
$itemobj->print_analysed($item, $printnr, $mygroupid);
// $itemnr = $itemobj->print_analysed($item, $itemnr, $mygroupid);
echo '</table>';
}
}else {
echo $OUTPUT->heading_with_help(get_string('insufficient_responses_for_this_group', 'feedback'), 'insufficient_responses', 'feedback');
} else {
echo $OUTPUT->heading_with_help(get_string('insufficient_responses_for_this_group', 'feedback'),
'insufficient_responses',
'feedback');
}
echo '</td></tr></table></div>';
echo $OUTPUT->box_end();