diff --git a/mod/scorm/report/basic/report.php b/mod/scorm/report/basic/report.php index d2f9f6840ea..a201cd444eb 100644 --- a/mod/scorm/report/basic/report.php +++ b/mod/scorm/report/basic/report.php @@ -155,11 +155,9 @@ class scorm_basic_report extends scorm_default_report { $table->sortable(true); $table->collapsible(true); + // This is done to prevent redundant data, when a user has multiple attempts $table->column_suppress('picture'); $table->column_suppress('fullname'); - // I wonder why it is doing all this suppress malarkey? - // However, if it was suppressing idnumber field before, I guess - // it needs to suppress all the user identity fields now foreach ($extrafields as $field) { $table->column_suppress($field); } @@ -521,17 +519,18 @@ class scorm_basic_report extends scorm_default_report { echo ''; } } - if (!$download) { - $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode')); - $mform->display(); - } } else { if ($candelete && !$download) { echo ''; echo ''; + $table->finish_output(); } echo ''; - echo $OUTPUT->notification(get_string('noactivity', 'scorm')); + } + // Show preferences form irrespective of attempts are there to report or not + if (!$download) { + $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode')); + $mform->display(); } if ($download == 'Excel' or $download == 'ODS') { $workbook->close(); diff --git a/mod/scorm/report/interactions/report.php b/mod/scorm/report/interactions/report.php index 12e61abdeb9..930d8356682 100644 --- a/mod/scorm/report/interactions/report.php +++ b/mod/scorm/report/interactions/report.php @@ -211,9 +211,9 @@ class scorm_interactions_report extends scorm_default_report { $table->sortable(true); $table->collapsible(true); + // This is done to prevent redundant data, when a user has multiple attempts $table->column_suppress('picture'); $table->column_suppress('fullname'); - // This is done to prevent redundant data, when a user has multiple attempts foreach ($extrafields as $field) { $table->column_suppress($field); } @@ -583,17 +583,18 @@ class scorm_interactions_report extends scorm_default_report { echo ''; } } - if (!$download) { - $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode')); - $mform->display(); - } } else { if ($candelete && !$download) { echo ''; echo ''; + $table->finish_output(); } echo ''; - echo $OUTPUT->notification(get_string('noactivity', 'scorm')); + } + // Show preferences form irrespective of attempts are there to report or not + if (!$download) { + $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode')); + $mform->display(); } if ($download == 'Excel' or $download == 'ODS') { $workbook->close();