From 99d36acade09be9c2e01e2effe67cb315894722c Mon Sep 17 00:00:00 2001
From: Sara Arjona <sara@moodle.com>
Date: Wed, 4 Dec 2024 14:11:41 +0100
Subject: [PATCH] MDL-82460 form: Remove adv icon from _advancedHTML

The "adv" icon was used in _advancedHTML but was not displayed anywhere,
so it has been deprecated to clean up the code.
---
 lang/en/deprecated.txt | 3 ++-
 lang/en/form.php       | 4 +++-
 lib/formslib.php       | 2 +-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/lang/en/deprecated.txt b/lang/en/deprecated.txt
index 078631c5185..f7a2b4a59cd 100644
--- a/lang/en/deprecated.txt
+++ b/lang/en/deprecated.txt
@@ -143,4 +143,5 @@ generalquestionbank,core_backup
 cannotdeletecategoryquestions,core_error
 errordeletingquestionsfromcategory,core_question
 importantupdates_content,core_admin
-importantupdates_title,core_admin
\ No newline at end of file
+importantupdates_title,core_admin
+advancedelement,core_form
diff --git a/lang/en/form.php b/lang/en/form.php
index 123ff4d5076..9c3e96ae6df 100644
--- a/lang/en/form.php
+++ b/lang/en/form.php
@@ -24,7 +24,6 @@
  */
 
 $string['addfields'] = 'Add {$a} field(s) to form';
-$string['advancedelement'] = 'Advanced element';
 $string['close'] = 'Close';
 $string['custom'] = 'Custom';
 $string['day'] = 'Day';
@@ -91,3 +90,6 @@ $string['timing'] = 'Timing';
 $string['togglesensitive'] = 'Toggle sensitive';
 $string['unmaskpassword'] = 'Unmask';
 $string['year'] = 'Year';
+
+// Deprecated since Moodle 5.0.
+$string['advancedelement'] = 'Advanced element';
diff --git a/lib/formslib.php b/lib/formslib.php
index 7cde8fab751..3784cd60b47 100644
--- a/lib/formslib.php
+++ b/lib/formslib.php
@@ -1775,7 +1775,7 @@ class MoodleQuickForm extends HTML_QuickForm_DHTMLRulesTableless {
             $this->updateAttributes(array('class'=>'mform'));
         }
         $this->_reqHTML = '<span class="req">' . $OUTPUT->pix_icon('req', get_string('requiredelement', 'form')) . '</span>';
-        $this->_advancedHTML = '<span class="adv">' . $OUTPUT->pix_icon('adv', get_string('advancedelement', 'form')) . '</span>';
+        $this->_advancedHTML = '<span class="adv"></span>';
         $this->setRequiredNote(get_string('somefieldsrequired', 'form', $OUTPUT->pix_icon('req', get_string('requiredelement', 'form'))));
     }