From 992159f450f3fb5c134da1dbdfa1fd33b15356cb Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Thu, 16 Oct 2014 13:49:44 +0100 Subject: [PATCH] MDL-18229 grade report: coding style fixes global definitions must be at the top of functions. --- grade/report/singleview/classes/local/screen/user.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/grade/report/singleview/classes/local/screen/user.php b/grade/report/singleview/classes/local/screen/user.php index ba2f59bd141..cdd56d94085 100644 --- a/grade/report/singleview/classes/local/screen/user.php +++ b/grade/report/singleview/classes/local/screen/user.php @@ -211,14 +211,14 @@ class user extends tablelike implements selectable_items { * @return grade_category */ private function category($item) { + global $DB; + if (empty($item->categoryid)) { if ($item->itemtype == 'course') { return $this->course->fullname; } - global $DB; - $params = array('id' => $item->iteminstance); $elem = $DB->get_record('grade_categories', $params); @@ -249,12 +249,12 @@ class user extends tablelike implements selectable_items { * @return string */ public function pager() { + global $OUTPUT; + if (!$this->supports_paging()) { return ''; } - global $OUTPUT; - return $OUTPUT->paging_bar( count($this->items), $this->page, $this->perpage, new moodle_url('/grade/report/singleview/index.php', array(