From 986c833743fa38f947572e41d741131a41fa03de Mon Sep 17 00:00:00 2001
From: Tim Lock <tim.lock@netspot.com.au>
Date: Thu, 11 Jul 2013 18:03:34 +0930
Subject: [PATCH] MDL-40626 gradebook: Prevent incorrect override with
 multiline feedback

The quick grading option doesn't allow mutliline editing.
---
 grade/report/grader/lib.php | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/grade/report/grader/lib.php b/grade/report/grader/lib.php
index 5782621bd63..9ee5b176d5a 100644
--- a/grade/report/grader/lib.php
+++ b/grade/report/grader/lib.php
@@ -226,6 +226,10 @@ class grade_report_grader extends grade_report {
                         $changedgrades = true;
 
                     } else if ($datatype === 'feedback') {
+                        // If quick grading is on, feedback needs to be compared without line breaks.
+                        if ($this->get_pref('quickgrading')) {
+                            $oldvalue->feedback = preg_replace("/\r\n|\r|\n/", "", $oldvalue->feedback);
+                        }
                         if (($oldvalue->feedback === $postedvalue) or ($oldvalue->feedback === NULL and empty($postedvalue))) {
                             continue;
                         }