From 97e84c80b0849ceeae1beaca9a9d44c86e700d99 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Wed, 4 Apr 2012 03:44:10 +0200 Subject: [PATCH] MDL-32149 remove some now breaking expectError() uses. I've tested that unit with debug developer, debug notices and debug none and it passes always. So, as far as I cannot find any reason to have those expectError() there... they are out now. --- lib/simpletest/testmathslib.php | 9 --------- 1 file changed, 9 deletions(-) diff --git a/lib/simpletest/testmathslib.php b/lib/simpletest/testmathslib.php index f1cfb5664de..cac7bd077f7 100644 --- a/lib/simpletest/testmathslib.php +++ b/lib/simpletest/testmathslib.php @@ -119,27 +119,18 @@ class mathsslib_test extends UnitTestCase { * Tests some slightly more complex expressions */ public function test__error_handling() { - if (debugging('', DEBUG_DEVELOPER)) { - $this->expectError(); - } $formula = new calc_formula('=pi( + a', array('a'=>10)); $res = $formula->evaluate(); $this->assertEqual($res, false); $this->assertEqual($formula->get_error(), get_string('unexpectedoperator', 'mathslib', '+')); - if (debugging('', DEBUG_DEVELOPER)) { - $this->expectError(); - } $formula = new calc_formula('=pi('); $res = $formula->evaluate(); $this->assertEqual($res, false); $this->assertEqual($formula->get_error(), get_string('expectingaclosingbracket', 'mathslib')); - if (debugging('', DEBUG_DEVELOPER)) { - $this->expectError(); - } $formula = new calc_formula('=pi()^'); $res = $formula->evaluate(); $this->assertEqual($res, false);