diff --git a/mod/forum/lib.php b/mod/forum/lib.php index 19a7f33df91..150cc3b6ded 100644 --- a/mod/forum/lib.php +++ b/mod/forum/lib.php @@ -743,8 +743,13 @@ function forum_print_overview($course,$lastaccess) { return; } // get all forum logs in ONE query (much better!) - $new = get_records_sql("SELECT instance,cmid,COUNT(l.id) as count FROM {$CFG->prefix}log l JOIN {$CFG->prefix}course_modules cm ON cm.id = cmid WHERE time > $lastaccess AND l.course = ".$course->id - ." AND l.module = 'forum' AND action LIKE 'add%' AND userid != ".$USER->id." GROUP BY cmid,instance"); + if (!$new = get_records_sql("SELECT instance,cmid,COUNT(l.id) as count FROM {$CFG->prefix}log l " + ." JOIN {$CFG->prefix}course_modules cm ON cm.id = cmid " + ." WHERE time > $lastaccess AND l.course = ".$course->id + ." AND l.module = 'forum' AND action LIKE 'add%' " + ." AND userid != ".$USER->id." GROUP BY cmid,instance")) { + $new = array(); // avoid warnings; + } foreach ($forums as $forum) { $count = 0; $unread = 0; @@ -3385,8 +3390,6 @@ function forum_tp_count_forum_read_records($userid, $forumid, $groupid=false) { $groupsel = ' AND (d.groupid = '.$groupid.' OR d.groupid = -1)'; } - error_log("forumcount"); - if ($CFG->dbtype === 'postgres7') { // this query takes 20ms, vs several minutes for the one below $sql = " SELECT COUNT (DISTINCT u.id ) "