From 950e44c82f9cf709e66821e637051548cde33f97 Mon Sep 17 00:00:00 2001 From: Shamim Rezaie Date: Tue, 8 Dec 2020 05:00:27 +1100 Subject: [PATCH] MDL-70173 theme_boost: Fix empty link issue on the "Go to top" button On behat, we have to use a more specific test step if we are looking for a "Go" button on a modal. The reason is that the html of the modal content is put after the html of the "Go to top" button, so behat may find the "Go to top" button if we just look for "Go". --- mod/quiz/tests/behat/editing_add.feature | 4 ++-- mod/quiz/tests/behat/editing_repaginate.feature | 6 +++--- theme/boost/templates/footer.mustache | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/mod/quiz/tests/behat/editing_add.feature b/mod/quiz/tests/behat/editing_add.feature index 41071b64cab..2952285fc0f 100644 --- a/mod/quiz/tests/behat/editing_add.feature +++ b/mod/quiz/tests/behat/editing_add.feature @@ -77,7 +77,7 @@ Feature: Edit quiz page - adding things When I press "Repaginate" Then I should see "Repaginate with" And I set the field "menuquestionsperpage" to "2" - When I press "Go" + When I click on "Go" "button" in the "Repaginate" "dialogue" And I should see "Essay 01 new" on quiz page "1" And I should see "Essay 02 new" on quiz page "1" And I should see "Essay 03 new" on quiz page "2" @@ -231,7 +231,7 @@ Feature: Edit quiz page - adding things When I press "Repaginate" Then I should see "Repaginate with" And I set the field "menuquestionsperpage" to "1" - When I press "Go" + When I click on "Go" "button" in the "Repaginate" "dialogue" And I should see "Essay 03" on quiz page "1" And I should see "Essay 01" on quiz page "2" And I should see "Essay 02" on quiz page "3" diff --git a/mod/quiz/tests/behat/editing_repaginate.feature b/mod/quiz/tests/behat/editing_repaginate.feature index 0fe66564419..37e4ac78057 100644 --- a/mod/quiz/tests/behat/editing_repaginate.feature +++ b/mod/quiz/tests/behat/editing_repaginate.feature @@ -107,7 +107,7 @@ Feature: Edit quiz page - pagination # Repaginate one question per page. When I press "Repaginate" And I set the field "menuquestionsperpage" to "1" - And I press "Go" + And I click on "Go" "button" in the "Repaginate" "dialogue" Then I should see "Essay 01 new" on quiz page "1" And I should see "Essay 02 new" on quiz page "2" And I should see "Essay 03 new" on quiz page "3" @@ -136,7 +136,7 @@ Feature: Edit quiz page - pagination # Repaginate with 2 questions per page. When I press "Repaginate" And I set the field "menuquestionsperpage" to "2" - And I press "Go" + And I click on "Go" "button" in the "Repaginate" "dialogue" Then I should see "Essay 01 new" on quiz page "1" And I should see "Essay 02 new" on quiz page "1" And I should see "Essay 03 new" on quiz page "2" @@ -145,7 +145,7 @@ Feature: Edit quiz page - pagination # Repaginate with unlimited questions per page (All questions on Page 1). When I press "Repaginate" And I set the field "menuquestionsperpage" to "Unlimited" - And I press "Go" + And I click on "Go" "button" in the "Repaginate" "dialogue" Then I should see "Essay 01 new" on quiz page "1" And I should see "Essay 02 new" on quiz page "1" And I should see "Essay 03 new" on quiz page "1" diff --git a/theme/boost/templates/footer.mustache b/theme/boost/templates/footer.mustache index 2655fd4635c..fca4e060938 100644 --- a/theme/boost/templates/footer.mustache +++ b/theme/boost/templates/footer.mustache @@ -19,8 +19,8 @@ }}