L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

quiz editing MDL-24750 The Add random button should also let you add questions from an existing category.

Browse Source 
Also includes a fix for MDL-24749 by Sam Hemelryk. Thanks Sam.

This commit also includes a certain amount of code cleaning up.
This commit is contained in:
Tim Hunt
2010-11-22 09:52:42 +00:00
parent d2e66a60a0
commit 94dbfb3a82
23 changed files with 276 additions and 304 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/type/questiontype.php
+4 -7
View File
@@ -305,7 +305,7 @@ class default_questiontype {
* redisplayed with validation errors, from validation_errors field, which
* is itself an object, shown next to the form fields. (I don't think this is accurate any more.)
*/
function save_question($question, $form, $course) {
function save_question($question, $form) {
global $USER, $DB, $OUTPUT;
list($question->category) = explode(',', $form->category);
@@ -364,10 +364,10 @@ class default_questiontype {
$question->modifiedby = $USER->id;
$question->timemodified = time();
if (!empty($question->questiontext)) {
if (!empty($question->questiontext) && !empty($form->questiontext['itemid'])) {
$question->questiontext = file_save_draft_area_files($form->questiontext['itemid'], $context->id, 'question', 'questiontext', (int)$question->id, $this->fileoptions, $question->questiontext);
}
if (!empty($question->generalfeedback)) {
if (!empty($question->generalfeedback) && !empty($form->generalfeedback['itemid'])) {
$question->generalfeedback = file_save_draft_area_files($form->generalfeedback['itemid'], $context->id, 'question', 'generalfeedback', (int)$question->id, $this->fileoptions, $question->generalfeedback);
}
$DB->update_record('question', $question);
@@ -392,10 +392,7 @@ class default_questiontype {
}
if (!empty($result->noticeyesno)) {
echo $OUTPUT->confirm($result->noticeyesno, "question.php?id=$question->id&courseid={$course->id}",
"edit.php?courseid={$course->id}");
echo $OUTPUT->footer();
exit;
throw new coding_exception('$result->noticeyesno no longer supported in save_question.');
}
// Give the question a unique version stamp determined by question_hash()