From 938d0763f6babf877be7ea79b3255abbfd49095d Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Fri, 20 Nov 2020 08:52:58 +0800 Subject: [PATCH] MDL-70148 behat: Wait after opening the user menu The version of Boost used in Moodle 3.5 does not have any pendingJS checks and it is not possible to add them. We need to use the poor-person's alternative and fall back to a short wait to allow the menu to open before interacting with it. This may still allow for failures on extremely slow systems but the risk is extremely minimal. --- admin/tool/behat/tests/behat/keyboard.feature | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/admin/tool/behat/tests/behat/keyboard.feature b/admin/tool/behat/tests/behat/keyboard.feature index ca9a74f02f3..76fc62c5c79 100644 --- a/admin/tool/behat/tests/behat/keyboard.feature +++ b/admin/tool/behat/tests/behat/keyboard.feature @@ -35,6 +35,11 @@ Feature: Verify that keyboard steps work as expected | saffronr | saffron.rutledge@example.com | Saffron | Rutledge | And I log in as "saffronr" And I click on "Saffron Rutledge" "link" in the ".usermenu" "css_element" + # The version of Boost used in Moodle 3.5 does not have any pendingJS checks and it is not possible to add them. + # We need to use the poor-person's alternative and fall back to a short wait to allow the menu to open before + # interacting with it. + # This may still allow for failures on extremely slow systems but the risk is extremely minimal. + And I wait "1" seconds When I press the up key Then the focused element is "Log out" "link"