From bb7eec388606553712be332b3781e2b59b561ba5 Mon Sep 17 00:00:00 2001 From: Daniel Ziegenberg Date: Mon, 18 Nov 2024 18:00:42 +0100 Subject: [PATCH] MDL-83752 workshop: Handle empty feedbackreviewer Causes PHP warnings when null on PHP 8.1. Signed-off-by: Daniel Ziegenberg --- mod/workshop/submission.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mod/workshop/submission.php b/mod/workshop/submission.php index acba1f697ca..47216f9f7ff 100644 --- a/mod/workshop/submission.php +++ b/mod/workshop/submission.php @@ -303,7 +303,7 @@ if ($isreviewer) { echo $output->render($assessment); if ($workshop->phase == workshop::PHASE_CLOSED) { - if (strlen(trim($userassessment->feedbackreviewer)) > 0) { + if (isset($userassessment->feedbackreviewer) && !empty(trim($userassessment->feedbackreviewer))) { echo $output->render(new workshop_feedback_reviewer($userassessment)); } } @@ -337,7 +337,7 @@ if (has_capability('mod/workshop:viewallassessments', $workshop->context) or ($o echo $output->render($displayassessment); if ($workshop->phase == workshop::PHASE_CLOSED and has_capability('mod/workshop:viewallassessments', $workshop->context)) { - if (strlen(trim($assessment->feedbackreviewer)) > 0) { + if (isset($assessment->feedbackreviewer) && !empty(trim($assessment->feedbackreviewer))) { echo $output->render(new workshop_feedback_reviewer($assessment)); } }