L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-32329 plugin manager returns plugins with unsatisfied dependencies

Browse Source
This commit is contained in:
David Mudrak
2012-05-30 10:35:28 +02:00
parent 4631e39533
commit 927cb51166
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/pluginlib.php
+15 -5
View File
@@ -280,25 +280,35 @@ class plugin_manager {
}
/**
* Checks all dependencies for all installed plugins. Used by install and upgrade.
* Checks all dependencies for all installed plugins
*
* This is used by install and upgrade. The array passed by reference as the second
* argument is populated with the list of plugins that have failed dependencies (note that
* a single plugin can appear multiple times in the $failedplugins).
*
* @param int $moodleversion the version from version.php.
* @param array $failedplugins to return the list of plugins with non-satisfied dependencies
* @return bool true if all the dependencies are satisfied for all plugins.
*/
public function all_plugins_ok($moodleversion) {
public function all_plugins_ok($moodleversion, &$failedplugins = array()) {
$return = true;
foreach ($this->get_plugins() as $type => $plugins) {
foreach ($plugins as $plugin) {
if (!empty($plugin->versionrequires) && $plugin->versionrequires > $moodleversion) {
return false;
$return = false;
$failedplugins[] = $plugin->component;
}
if (!$this->are_dependencies_satisfied($plugin->get_other_required_plugins())) {
return false;
$return = false;
$failedplugins[] = $plugin->component;
}
}
}
return true;
return $return;
}
/**