diff --git a/grade/edit/edit_calculation.php b/grade/edit/edit_calculation.php new file mode 100644 index 00000000000..0055e265b08 --- /dev/null +++ b/grade/edit/edit_calculation.php @@ -0,0 +1,6 @@ + \ No newline at end of file diff --git a/grade/edit/edit_calculation_form.php b/grade/edit/edit_calculation_form.php new file mode 100644 index 00000000000..e69de29bb2d diff --git a/grade/report/grader/edit_category.php b/grade/edit/edit_category.php similarity index 88% rename from grade/report/grader/edit_category.php rename to grade/edit/edit_category.php index c00af909c56..6446ddb7293 100644 --- a/grade/report/grader/edit_category.php +++ b/grade/edit/edit_category.php @@ -1,6 +1,6 @@ libdir.'/gradelib.php'; require_once 'edit_category_form.php'; @@ -17,7 +17,7 @@ $context = get_context_instance(CONTEXT_COURSE, $course->id); //require_capability() here!! // default return url -$returnurl = 'category.php?id='.$course->id; +$returnurl = 'edit_tree.php?id='.$course->id; $mform = new edit_category_form(); @@ -50,7 +50,6 @@ $strgraderreport = get_string('graderreport', 'grades'); $strcategoriesedit = get_string('categoriesedit', 'grades'); $nav = array(array('name'=>$strgrades,'link'=>$CFG->wwwroot.'/grade/index.php?id='.$courseid, 'type'=>'misc'), - array('name'=>$strgraderreport, 'link'=>$CFG->wwwroot.'/grade/report.php?id='.$courseid.'&report=grader', 'type'=>'misc'), array('name'=>$strcategoriesedit, 'link'=>'', 'type'=>'misc')); $navigation = build_navigation($nav); diff --git a/grade/report/grader/edit_category_form.php b/grade/edit/edit_category_form.php similarity index 100% rename from grade/report/grader/edit_category_form.php rename to grade/edit/edit_category_form.php diff --git a/grade/report/grader/edit_grade.php b/grade/edit/edit_grade.php similarity index 94% rename from grade/report/grader/edit_grade.php rename to grade/edit/edit_grade.php index 5052c7660f6..dd083b98859 100644 --- a/grade/report/grader/edit_grade.php +++ b/grade/edit/edit_grade.php @@ -1,6 +1,6 @@ libdir.'/gradelib.php'; require_once 'edit_grade_form.php'; @@ -18,6 +18,7 @@ $context = get_context_instance(CONTEXT_COURSE, $course->id); require_capability('gradereport/grader:manage', $context); // default return url +//TODO: implement proper return support $returnurl = $CFG->wwwroot.'/grade/report.php?report=grader&id='.$course->id; $grade_grades = get_record('grade_grades', 'id', $id); @@ -26,9 +27,9 @@ $gradeitem = get_record('grade_items', 'id', $grade_grades->itemid); $mform = new edit_grade_form(qualified_me(), array('gradeitem'=>$gradeitem)); if ($grade_grades = get_record('grade_grades', 'id', $id)) { if ($grade_text = get_record('grade_grades_text', 'gradeid', $id)) { - $mform->set_data($grade_text); - } - + $mform->set_data($grade_text); + } + $grade_grades->locked = $grade_grades->locked > 0 ? 1:0; $grade_grades->courseid = $courseid; $mform->set_data($grade_grades); @@ -41,16 +42,16 @@ if ($mform->is_cancelled()) { redirect($returnurl); // form processing } else if ($data = $mform->get_data()) { - + $grade_grades = new grade_grades(array('id'=>$id)); $grade_item = new grade_item(array('id'=>$grade_grades->itemid)); $grade_item->update_final_grade($grade_grades->userid, $data->finalgrade, NULL, NULL, $data->feedback); - + // set locked $grade_grades->set_locked($data->locked); // set hidden $grade_grades->set_hidden($data->hidden); - + // set locktime $grade_grades->set_locktime($data->locktime); @@ -95,7 +96,6 @@ if (!empty($action) && $action == 'view' && !empty($grade_text->feedback)) { } $nav = array(array('name'=>$strgrades,'link'=>$CFG->wwwroot.'/grade/index.php?id='.$courseid, 'type'=>'misc'), - array('name'=>$strgraderreport, 'link'=>$CFG->wwwroot.'/grade/report.php?id='.$courseid.'&report=grader', 'type'=>'misc'), array('name'=>$heading, 'link'=>'', 'type'=>'misc')); $navigation = build_navigation($nav); diff --git a/grade/report/grader/edit_grade_form.php b/grade/edit/edit_grade_form.php similarity index 93% rename from grade/report/grader/edit_grade_form.php rename to grade/edit/edit_grade_form.php index 17088e59204..43d73db3a0a 100755 --- a/grade/report/grader/edit_grade_form.php +++ b/grade/edit/edit_grade_form.php @@ -7,9 +7,9 @@ class edit_grade_form extends moodleform { global $CFG, $USER; $mform =& $this->_form; - - $gradeitem = $this->_customdata['gradeitem']; - + + $gradeitem = $this->_customdata['gradeitem']; + /// actual grade - numeric or scale if ($gradeitem->gradetype == 1) { // numeric grade @@ -17,7 +17,7 @@ class edit_grade_form extends moodleform { } else if ($gradeitem->gradetype == 2) { // scale grade $scaleopt[-1] = get_string('nograde'); - + $i = 1; if ($scale = get_record('scale', 'id', $gradeitem->scaleid)) { foreach (split(",", $scale->scale) as $option) { @@ -25,13 +25,13 @@ class edit_grade_form extends moodleform { $i++; } } - + $mform->addElement('select', 'finalgrade', get_string('finalgrade', 'grades'), $scaleopt); } - + /// hidden - $mform->addElement('advcheckbox', 'hidden', get_string('hidden', 'grades')); - + $mform->addElement('advcheckbox', 'hidden', get_string('hidden', 'grades')); + /// locked $mform->addElement('advcheckbox', 'locked', get_string('locked', 'grades')); @@ -39,7 +39,7 @@ class edit_grade_form extends moodleform { $mform->addElement('date_time_selector', 'locktime', get_string('locktime', 'grades'), array('optional'=>true)); $mform->disabledIf('locktime', 'gradetype', 'eq', GRADE_TYPE_NONE); /// hidden/visible - + /// feedback $feedbackformat = get_user_preferences('grade_report_feedbackformat', $CFG->grade_report_feedbackformat); diff --git a/grade/report/grader/edit_item.php b/grade/edit/edit_item.php similarity index 89% rename from grade/report/grader/edit_item.php rename to grade/edit/edit_item.php index faaf5aaf0db..d7100742059 100644 --- a/grade/report/grader/edit_item.php +++ b/grade/edit/edit_item.php @@ -1,5 +1,5 @@ libdir.'/gradelib.php'; require_once 'edit_item_form.php'; @@ -16,7 +16,7 @@ $context = get_context_instance(CONTEXT_COURSE, $course->id); //require_capability() here!! // default return url -$returnurl = 'category.php?id='.$course->id; +$returnurl = 'edit_tree.php?id='.$course->id; $mform = new edit_item_form(); if ($item = get_record('grade_items', 'id', $id, 'courseid', $course->id)) { @@ -54,7 +54,6 @@ $strgraderreport = get_string('graderreport', 'grades'); $stritemsedit = get_string('itemsedit', 'grades'); $nav = array(array('name'=>$strgrades,'link'=>$CFG->wwwroot.'/grade/index.php?id='.$courseid, 'type'=>'misc'), - array('name'=>$strgraderreport, 'link'=>$CFG->wwwroot.'/grade/report.php?id='.$courseid.'&report=grader', 'type'=>'misc'), array('name'=>$stritemsedit, 'link'=>'', 'type'=>'misc')); $navigation = build_navigation($nav); diff --git a/grade/report/grader/edit_item_form.php b/grade/edit/edit_item_form.php similarity index 100% rename from grade/report/grader/edit_item_form.php rename to grade/edit/edit_item_form.php diff --git a/grade/report/grader/category.php b/grade/edit/edit_tree.php similarity index 77% rename from grade/report/grader/category.php rename to grade/edit/edit_tree.php index 511208925ef..5fbf92a7ada 100644 --- a/grade/report/grader/category.php +++ b/grade/edit/edit_tree.php @@ -24,7 +24,7 @@ // // /////////////////////////////////////////////////////////////////////////// -require_once '../../../config.php'; +require_once '../../config.php'; require_once $CFG->libdir.'/gradelib.php'; $courseid = required_param('id', PARAM_INT); @@ -44,7 +44,7 @@ $context = get_context_instance(CONTEXT_COURSE, $course->id); //require_capability() here!! // default return url -$returnurl = 'category.php?id='.$course->id; +$returnurl = 'edit_tree.php?id='.$course->id; // get the grading tree object // note: total must be first for moving to work correctly, if you want it last moving code must be rewritten! @@ -67,7 +67,6 @@ $strgraderreport = get_string('graderreport', 'grades'); $strcategoriesedit = get_string('categoriesedit', 'grades'); $nav = array(array('name'=>$strgrades,'link'=>$CFG->wwwroot.'/grade/index.php?id='.$courseid, 'type'=>'misc'), - array('name'=>$strgraderreport, 'link'=>$CFG->wwwroot.'/grade/report.php?id='.$courseid.'&report=grader', 'type'=>'misc'), array('name'=>$strcategoriesedit, 'link'=>'', 'type'=>'misc')); $navigation = build_navigation($nav); @@ -97,7 +96,7 @@ switch ($action) { $strdeletecheckfull = get_string('deletecheck', '', $object->get_name()); $optionsyes = array('eid'=>$eid, 'confirm'=>1, 'sesskey'=>sesskey(), 'id'=>$course->id, 'action'=>'delete'); $optionsno = array('id'=>$course->id); - notice_yesno($strdeletecheckfull, 'category.php', 'category.php', $optionsyes, $optionsno, 'post', 'get'); + notice_yesno($strdeletecheckfull, 'edit_tree.php', 'edit_tree.php', $optionsyes, $optionsno, 'post', 'get'); print_footer($course); die; } @@ -173,8 +172,9 @@ print_header_simple($strgrades . ': ' . $strgraderreport, ': ' . $strcategoriese print_heading(get_string('categoriesedit', 'grades')); // Add tabs -$currenttab = 'editcategory'; -include('tabs.php'); +// TODO: implement return support - use tabs from the report plugin +/*$currenttab = 'editcategory'; +include('tabs.php');*/ print_box_start('gradetreebox generalbox'); echo '
';
+ $actions = '
';
if ($element['type'] == 'item' or ($element['type'] == 'category' and $element['depth'] > 1)) {
- $actions .= '
';
- $actions .= '
';
+ $actions .= '
';
+ $actions .= '
';
}
if ($object->is_locked()) {
- $actions .= '
';
+ $actions .= '
';
} else {
- $actions .= '
';
+ $actions .= '
';
}
if ($object->is_hidden()) {
$name = ''.$object->get_name().'';
- $actions .= '
';
+ $actions .= '
';
} else {
$name = $object->get_name();
- $actions .= '
';
+ $actions .= '
';
}
/// prepare icon
@@ -260,7 +260,7 @@ function print_grade_tree($element, $moving) {
$moveto = '';
if ($moving) {
$actions = ''; // no action icons when moving
- $moveto = '

'. "\n";
- $edit_item_icon = ''
+ $edit_item_icon = ''
. '
'. "\n";
$overlib = '';
@@ -995,7 +995,7 @@ class grade_report_grader {
. $strfeedback.'\');" onmouseout="return nd();"';
}
- $edit_grade_icon = ''
+ $edit_grade_icon = ''
. '
'. "\n";
@@ -1004,7 +1004,7 @@ class grade_report_grader {
if ($type == 'item' or $type == 'courseitem' or $type == 'categoryitem') {
// show calculation icon only when calculation possible
if (!$object->is_normal_item() and ($object->gradetype == GRADE_TYPE_SCALE or $object->gradetype == GRADE_TYPE_VALUE)) {
- $edit_calculation_icon = ''
+ $edit_calculation_icon = ''
. '
'. "\n";
}
diff --git a/grade/report/grader/tabs.php b/grade/report/grader/tabs.php
index c3ad0973670..71ff26bf547 100644
--- a/grade/report/grader/tabs.php
+++ b/grade/report/grader/tabs.php
@@ -5,7 +5,7 @@
get_string('graderreport', 'grades'));
$row[] = new tabobject('editcategory',
- $CFG->wwwroot.'/grade/report/grader/category.php?id='.$courseid,
+ $CFG->wwwroot.'/grade/edit/edit_tree.php?id='.$courseid,
get_string('categoriesedit', 'grades'));
$row[] = new tabobject('preferences',
diff --git a/grade/report/user/index.php b/grade/report/user/index.php
index 6920fb8d9ab..28f24bdc94c 100644
--- a/grade/report/user/index.php
+++ b/grade/report/user/index.php
@@ -163,11 +163,11 @@ $numusers = count(get_role_users(@implode(',', $CFG->gradebookroles), $context))
}
$table->add_data($data);
}
-
+
//echo "| asdfas |