From 91c49d92338983d99d4d6d82d12babfa45d422d2 Mon Sep 17 00:00:00 2001 From: Petr Skoda Date: Sat, 18 Sep 2010 12:51:47 +0000 Subject: [PATCH] improved variable initialisation --- mod/feedback/complete_guest.php | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mod/feedback/complete_guest.php b/mod/feedback/complete_guest.php index 0d5e808d8da..5885f2d77e9 100644 --- a/mod/feedback/complete_guest.php +++ b/mod/feedback/complete_guest.php @@ -270,7 +270,7 @@ echo $OUTPUT->heading(format_text($feedback->name)); if( (intval($feedback->publish_stats) == 1) AND - ( has_capability('mod/feedback:viewanalysepage', $context)) AND + ( has_capability('mod/feedback:viewanalysepage', $context)) AND !( has_capability('mod/feedback:viewreports', $context)) ) { echo $OUTPUT->box_start('mdl-align'); echo ''.get_string('completed_feedbacks', 'feedback').''; @@ -336,11 +336,11 @@ } echo $OUTPUT->box_start('feedback_items'); - unset($startitem); + $startitem = null; $itemnr = $DB->count_records_select('feedback_item', 'feedback = ? AND hasvalue = 1 AND position < ?', array($feedback->id, $startposition)); $lastbreakposition = 0; $align = right_to_left() ? 'right' : 'left'; - + foreach($feedbackitems as $feedbackitem){ if(!isset($startitem)) { //avoid showing double pagebreaks @@ -349,7 +349,7 @@ } $startitem = $feedbackitem; } - + if($feedbackitem->dependitem > 0) { //chech if the conditions are ok if(!isset($feedbackcompletedtmp->id) OR !feedback_compare_item_value($feedbackcompletedtmp->id, $feedbackitem->dependitem, $feedbackitem->dependvalue, true)) { @@ -358,13 +358,13 @@ continue; } } - + if($feedbackitem->dependitem > 0) { $dependstyle = ' feedback_complete_depend'; }else { $dependstyle = ''; } - + echo $OUTPUT->box_start('feedback_item_box_'.$align.$dependstyle); $value = ''; //get the value