From 90be3a42f330ca023e11b2dcf887b4b0aa969951 Mon Sep 17 00:00:00 2001 From: Mihail Geshoski Date: Fri, 26 Oct 2018 09:16:10 +0800 Subject: [PATCH] MDL-63690 core_privacy: Handle when add_users() receives an empty array --- privacy/classes/local/request/userlist.php | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/privacy/classes/local/request/userlist.php b/privacy/classes/local/request/userlist.php index 0664f14eda6..171ccc07eb1 100644 --- a/privacy/classes/local/request/userlist.php +++ b/privacy/classes/local/request/userlist.php @@ -80,12 +80,13 @@ class userlist extends userlist_base { public function add_users(array $userids) : userlist { global $DB; - list($useridsql, $useridparams) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED); - $sql = "SELECT DISTINCT u.id - FROM {user} u - WHERE u.id {$useridsql}"; - $this->add_from_sql('id', $sql, $useridparams); - + if (!empty($userids)) { + list($useridsql, $useridparams) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED); + $sql = "SELECT DISTINCT u.id + FROM {user} u + WHERE u.id {$useridsql}"; + $this->add_from_sql('id', $sql, $useridparams); + } return $this; }