From 8ec33d16c7e044621dd9f47e7b19d9c6edd5f469 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Thu, 25 Jul 2024 23:00:27 +0100 Subject: [PATCH] MDL-82608 mod_data: null content checks when editing fields. --- mod/data/field/multimenu/field.class.php | 4 ++-- mod/data/field/radiobutton/field.class.php | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/mod/data/field/multimenu/field.class.php b/mod/data/field/multimenu/field.class.php index 301f109bf5f..9919ce4c061 100644 --- a/mod/data/field/multimenu/field.class.php +++ b/mod/data/field/multimenu/field.class.php @@ -64,8 +64,8 @@ class data_field_multimenu extends data_field_base { $content = array(); } } else if ($recordid) { - $content = $DB->get_field('data_content', 'content', array('fieldid'=>$this->field->id, 'recordid'=>$recordid)); - $content = explode('##', $content); + $contentfield = $DB->get_field('data_content', 'content', ['fieldid' => $this->field->id, 'recordid' => $recordid]); + $content = explode('##', $contentfield ?? ''); } else { $content = array(); } diff --git a/mod/data/field/radiobutton/field.class.php b/mod/data/field/radiobutton/field.class.php index 7b17ac935a9..666d8b7f00d 100644 --- a/mod/data/field/radiobutton/field.class.php +++ b/mod/data/field/radiobutton/field.class.php @@ -63,7 +63,8 @@ class data_field_radiobutton extends data_field_base { $content = ''; } } else if ($recordid) { - $content = trim($DB->get_field('data_content', 'content', array('fieldid'=>$this->field->id, 'recordid'=>$recordid))); + $contentfield = $DB->get_field('data_content', 'content', ['fieldid' => $this->field->id, 'recordid' => $recordid]); + $content = trim($contentfield ?? ''); } else { $content = ''; }