From 8ec5fefde703f0d45ecfc80c900d10374ea1358d Mon Sep 17 00:00:00 2001 From: Jun Pataleta Date: Tue, 25 Mar 2025 00:05:54 +0800 Subject: [PATCH] MDL-84991 editor_tiny: Improve lang string generation instructions --- lib/editor/tiny/readme_moodle.md | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/lib/editor/tiny/readme_moodle.md b/lib/editor/tiny/readme_moodle.md index 5037b2ba5ed..01c0d89e134 100644 --- a/lib/editor/tiny/readme_moodle.md +++ b/lib/editor/tiny/readme_moodle.md @@ -102,15 +102,19 @@ sed -i "/string\['tiny:/d" "${MOODLEDIR}/lang/en/editor_tiny.php" cat strings.php >> "${MOODLEDIR}/lang/en/editor_tiny.php" ``` -7. Commit changes. Note: You may need to review individual language changes which do not meet Moodle's guidelines. -8. If required, the remaining language strings can be fed into AMOS. +7. Review the changes to the language strings file carefully. You may need to: + + * Edit new strings so they meet [Moodle's guidelines for language strings](https://moodledev.io/general/development/policies/codingstyle#language-strings). + * Revert changes to any Moodle-updated language strings that were fixed for spelling, grammar, and consistency in past releases to meet Moodle's guidelines. For example, from the [`en_fix` issues](https://tracker.moodle.org/issues/?jql=summary%20~%20%22en_fix%22%20order%20by%20createdDate%20desc). Review the `git` history of the language strings file to verify. + +8. Commit the changes. + +9. If required, the remaining language strings can be fed into AMOS. --- **Note:** A set of language files are also generated for all supported translations and may be submitted to AMOS if desired. -**Note:** You will need to manually check for any Moodle-updated language strings as part of this change (for example any from the en_fixes). - --- ## Security fix procedure for TinyMCE Editor