From 8d8e6694c8cc8fac7d2a902efa5ff0f27b9dbc9f Mon Sep 17 00:00:00 2001 From: Andreas Grabs Date: Sun, 31 Oct 2010 22:05:57 +0000 Subject: [PATCH] MDL-24958 - bad permission check on anonymous feedbacks --- mod/feedback/complete_guest.php | 2 ++ mod/feedback/version.php | 2 +- mod/feedback/view.php | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/mod/feedback/complete_guest.php b/mod/feedback/complete_guest.php index 5885f2d77e9..6000f1eea85 100644 --- a/mod/feedback/complete_guest.php +++ b/mod/feedback/complete_guest.php @@ -98,6 +98,8 @@ if(isset($CFG->feedback_allowfullanonymous) AND $CFG->feedback_allowfullanonymous + AND $course->id == SITEID + AND (!$courseid OR $courseid == SITEID) AND $feedback->anonymous == FEEDBACK_ANONYMOUS_YES ) { $feedback_complete_cap = true; } diff --git a/mod/feedback/version.php b/mod/feedback/version.php index 17aa99081fc..7f0154590ef 100644 --- a/mod/feedback/version.php +++ b/mod/feedback/version.php @@ -9,7 +9,7 @@ */ - $module->version = 2010102300; // The current module version (Date: YYYYMMDDXX) + $module->version = 2010103100; // The current module version (Date: YYYYMMDDXX) $module->requires = 2010080300; // Requires this Moodle version $feedback_version_intern = 1; //this version is used for restore older backups $module->cron = 0; // Period for cron to check this module (secs) diff --git a/mod/feedback/view.php b/mod/feedback/view.php index c5a6e60ff30..0b73791ba7c 100644 --- a/mod/feedback/view.php +++ b/mod/feedback/view.php @@ -40,6 +40,8 @@ if(has_capability('mod/feedback:complete', $context)) { if(isset($CFG->feedback_allowfullanonymous) AND $CFG->feedback_allowfullanonymous + AND $course->id == SITEID + AND (!$courseid OR $courseid == SITEID) AND $feedback->anonymous == FEEDBACK_ANONYMOUS_YES ) { $feedback_complete_cap = true; }