MDL-57920 mod_data: Fix var dynamic creation (failing in php7)

2017-03-30 09:26:27 +02:00
parent 57ab070e01
commit 8cc04bcc67
1 changed files with 6 additions and 2 deletions
@@ -742,8 +742,12 @@ class mod_data_external extends external_api {
            $fn = $ln = ''; // Defaults for first and last name.
            // Force defaults for advanced search.
            foreach ($params['advsearch'] as $adv) {
-                if ($adv['name'] == 'fn' || $adv['name'] == 'ln') {
-                    $$adv['name'] = json_decode($adv['value']);
+                if ($adv['name'] == 'fn') {
+                    $fn = json_decode($adv['value']);
+                    continue;
+                }
+                if ($adv['name'] == 'ln') {
+                    $ln = json_decode($adv['value']);
                    continue;
                }
                $defaults[$adv['name']] = json_decode($adv['value']);