From 8b3d6c32599c296ff3003a93bc4c2da79c32d007 Mon Sep 17 00:00:00 2001
From: Andrew Nicols <andrew@nicols.co.uk>
Date: Tue, 4 Feb 2025 22:12:30 +0800
Subject: [PATCH] MDL-84421 tool_uploadcourse: Stop MUC caching enrol instances

We should not normally cache instances of a class. This can lead to poor
design to work around the limitations of PHP Serialization, and could
theoretically cause issues with PHP versions changing within a Moodle
version.
---
 admin/tool/uploadcourse/classes/helper.php | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/admin/tool/uploadcourse/classes/helper.php b/admin/tool/uploadcourse/classes/helper.php
index 80585b8cd90..d64afcbbddc 100644
--- a/admin/tool/uploadcourse/classes/helper.php
+++ b/admin/tool/uploadcourse/classes/helper.php
@@ -177,12 +177,7 @@ class tool_uploadcourse_helper {
      * @return enrol_plugin[]
      */
     public static function get_enrolment_plugins() {
-        $cache = cache::make('tool_uploadcourse', 'helper');
-        if (($enrol = $cache->get('enrol')) === false) {
-            $enrol = enrol_get_plugins(false);
-            $cache->set('enrol', $enrol);
-        }
-        return $enrol;
+        return enrol_get_plugins(false);
     }
 
     /**