From 8aab39c1d22e9e287bb639942c345736d4d86d2e Mon Sep 17 00:00:00 2001 From: "Tuan.Dinh" Date: Thu, 12 Nov 2020 10:18:43 +0700 Subject: [PATCH] MDL-70124 course: Activity names are now trimmed. --- course/classes/output/course_module_name.php | 5 +++-- course/moodleform_mod.php | 5 +++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/course/classes/output/course_module_name.php b/course/classes/output/course_module_name.php index 5602b21d011..709846c4e71 100644 --- a/course/classes/output/course_module_name.php +++ b/course/classes/output/course_module_name.php @@ -90,8 +90,9 @@ class course_module_name extends \core\output\inplace_editable { // Check access. \external_api::validate_context($context); require_capability('moodle/course:manageactivities', $context); - // Update value. - set_coursemodule_name($itemid, $newvalue); + + // Trim module name and Update value. + set_coursemodule_name($itemid, trim($newvalue)); $coursemodulerecord = get_coursemodule_from_id('', $itemid, 0, false, MUST_EXIST); // Return instance. $cm = get_fast_modinfo($coursemodulerecord->course)->get_cm($itemid); diff --git a/course/moodleform_mod.php b/course/moodleform_mod.php index 2bbdac012dc..59a93ef2aaa 100644 --- a/course/moodleform_mod.php +++ b/course/moodleform_mod.php @@ -1258,6 +1258,11 @@ abstract class moodleform_mod extends moodleform { $data->gradepass = unformat_float($data->gradepass); } + // Trim name for all activity name. + if (isset($data->name)) { + $data->name = trim($data->name); + } + $this->data_postprocessing($data); } return $data;