From 101ec5fd3b91227a1e042729978d3940aeff6499 Mon Sep 17 00:00:00 2001 From: Jetha Chan Date: Fri, 23 May 2014 15:59:14 +0800 Subject: [PATCH] MDL-44482 mod_lti: use localized dates Fixed an issue where LTI external tools had creation datestamps of NaN/NaN/NaN under particular non-English languages. --- mod/lti/locallib.php | 2 +- mod/lti/settings.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/mod/lti/locallib.php b/mod/lti/locallib.php index bb50e8bbb82..4b282cd8268 100644 --- a/mod/lti/locallib.php +++ b/mod/lti/locallib.php @@ -359,7 +359,7 @@ function lti_get_tool_table($tools, $id) { "; foreach ($tools as $type) { - $date = userdate($type->timecreated); + $date = userdate($type->timecreated, get_string('strftimedatefullshort', 'core_langconfig')); $accept = get_string('accept', 'lti'); $update = get_string('update', 'lti'); $delete = get_string('delete', 'lti'); diff --git a/mod/lti/settings.php b/mod/lti/settings.php index ad754376956..20ca0625e94 100644 --- a/mod/lti/settings.php +++ b/mod/lti/settings.php @@ -143,7 +143,7 @@ if ($ADMIN->fulltree) { var configuredColumns = [ {key:'name', label:'$typename', sortable:true}, {key:'baseURL', label:'$baseurl', sortable:true}, - {key:'timecreated', label:'$createdon', sortable:true, formatter:Y.YUI2.widget.DataTable.formatDate}, + {key:'timecreated', label:'$createdon', sortable:true}, {key:'action', label:'$action'} ]; @@ -152,7 +152,7 @@ if ($ADMIN->fulltree) { fields: [ {key:'name'}, {key:'baseURL'}, - {key:'timecreated', parser:'date'}, + {key:'timecreated'}, {key:'action'} ] };