From bdc518b5073baf96bfb026463c597a64581b23a5 Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Fri, 5 Apr 2013 15:14:44 +0800
Subject: [PATCH 1/2] MDL-35073 badges: fix duplicate indexes

---
 lib/db/install.xml | 11 +----------
 lib/db/upgrade.php | 10 ----------
 2 files changed, 1 insertion(+), 20 deletions(-)

diff --git a/lib/db/install.xml b/lib/db/install.xml
index 7c7eb5f582d..a38d31103bb 100755
--- a/lib/db/install.xml
+++ b/lib/db/install.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8" ?>
-<XMLDB PATH="lib/db" VERSION="20130402" COMMENT="XMLDB file for core Moodle tables"
+<XMLDB PATH="lib/db" VERSION="20130405" COMMENT="XMLDB file for core Moodle tables"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:noNamespaceSchemaLocation="../../lib/xmldb/xmldb.xsd"
 >
@@ -2977,7 +2977,6 @@
         <KEY NAME="fk_badgeid" TYPE="foreign" FIELDS="badgeid" REFTABLE="badge" REFFIELDS="id"/>
       </KEYS>
       <INDEXES>
-        <INDEX NAME="badgeid" UNIQUE="false" FIELDS="badgeid"/>
         <INDEX NAME="criteriatype" UNIQUE="false" FIELDS="criteriatype"/>
         <INDEX NAME="badgecriteriatype" UNIQUE="true" FIELDS="badgeid, criteriatype"/>
       </INDEXES>
@@ -2993,9 +2992,6 @@
         <KEY NAME="primary" TYPE="primary" FIELDS="id"/>
         <KEY NAME="fk_critid" TYPE="foreign" FIELDS="critid" REFTABLE="badge_criteria" REFFIELDS="id"/>
       </KEYS>
-      <INDEXES>
-        <INDEX NAME="critid" UNIQUE="false" FIELDS="critid"/>
-      </INDEXES>
     </TABLE>
     <TABLE NAME="badge_issued" COMMENT="Defines issued badges">
       <FIELDS>
@@ -3014,8 +3010,6 @@
         <KEY NAME="fk_userid" TYPE="foreign" FIELDS="userid" REFTABLE="user" REFFIELDS="id"/>
       </KEYS>
       <INDEXES>
-        <INDEX NAME="badgeid" UNIQUE="false" FIELDS="badgeid"/>
-        <INDEX NAME="userid" UNIQUE="false" FIELDS="userid"/>
         <INDEX NAME="badgeuser" UNIQUE="true" FIELDS="badgeid, userid"/>
       </INDEXES>
     </TABLE>
@@ -3066,9 +3060,6 @@
         <KEY NAME="primary" TYPE="primary" FIELDS="id"/>
         <KEY NAME="fk_userid" TYPE="foreign" FIELDS="userid" REFTABLE="user" REFFIELDS="id"/>
       </KEYS>
-      <INDEXES>
-        <INDEX NAME="userid" UNIQUE="false" FIELDS="userid"/>
-      </INDEXES>
     </TABLE>
   </TABLES>
 </XMLDB>
diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index d0b1be9fcb6..57e29622d0c 100644
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -1843,7 +1843,6 @@ function xmldb_main_upgrade($oldversion) {
         $table->add_key('fk_badgeid', XMLDB_KEY_FOREIGN, array('badgeid'), 'badge', array('id'));
 
         // Adding indexes to table 'badge_criteria'.
-        $table->add_index('badgeid', XMLDB_INDEX_NOTUNIQUE, array('badgeid'));
         $table->add_index('criteriatype', XMLDB_INDEX_NOTUNIQUE, array('criteriatype'));
         $table->add_index('badgecriteriatype', XMLDB_INDEX_UNIQUE, array('badgeid', 'criteriatype'));
 
@@ -1865,9 +1864,6 @@ function xmldb_main_upgrade($oldversion) {
         $table->add_key('primary', XMLDB_KEY_PRIMARY, array('id'));
         $table->add_key('fk_critid', XMLDB_KEY_FOREIGN, array('critid'), 'badge_criteria', array('id'));
 
-        // Adding indexes to table 'badge_criteria_param'.
-        $table->add_index('critid', XMLDB_INDEX_NOTUNIQUE, array('critid'));
-
         // Conditionally launch create table for 'badge_criteria_param'.
         if (!$dbman->table_exists($table)) {
             $dbman->create_table($table);
@@ -1891,9 +1887,6 @@ function xmldb_main_upgrade($oldversion) {
         $table->add_key('fk_badgeid', XMLDB_KEY_FOREIGN, array('badgeid'), 'badge', array('id'));
         $table->add_key('fk_userid', XMLDB_KEY_FOREIGN, array('userid'), 'user', array('id'));
 
-        // Adding indexes to table 'badge_issued'.
-        $table->add_index('badgeid', XMLDB_INDEX_NOTUNIQUE, array('badgeid'));
-        $table->add_index('userid', XMLDB_INDEX_NOTUNIQUE, array('userid'));
         $table->add_index('badgeuser', XMLDB_INDEX_UNIQUE, array('badgeid', 'userid'));
 
         // Conditionally launch create table for 'badge_issued'.
@@ -1962,9 +1955,6 @@ function xmldb_main_upgrade($oldversion) {
         $table->add_key('primary', XMLDB_KEY_PRIMARY, array('id'));
         $table->add_key('fk_userid', XMLDB_KEY_FOREIGN, array('userid'), 'user', array('id'));
 
-        // Adding indexes to table 'badge_backpack'.
-        $table->add_index('userid', XMLDB_INDEX_NOTUNIQUE, array('userid'));
-
         // Conditionally launch create table for 'badge_backpack'.
         if (!$dbman->table_exists($table)) {
             $dbman->create_table($table);

From 2916ca61beff3d3bba9417be9acb932e5ec08ff1 Mon Sep 17 00:00:00 2001
From: Dan Poltawski <dan@moodle.com>
Date: Fri, 5 Apr 2013 03:44:28 -0400
Subject: [PATCH 2/2] MDL-35073 badges: fix incorrect fk name

Good spotting Damyon!
---
 lib/db/install.xml | 2 +-
 lib/db/upgrade.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/db/install.xml b/lib/db/install.xml
index a38d31103bb..ce95ce07454 100755
--- a/lib/db/install.xml
+++ b/lib/db/install.xml
@@ -3039,7 +3039,7 @@
       </FIELDS>
       <KEYS>
         <KEY NAME="primary" TYPE="primary" FIELDS="id"/>
-        <KEY NAME="fk_badgeid" TYPE="foreign" FIELDS="id" REFTABLE="badge" REFFIELDS="id"/>
+        <KEY NAME="fk_badgeid" TYPE="foreign" FIELDS="badgeid" REFTABLE="badge" REFFIELDS="id"/>
         <KEY NAME="fk_recipientid" TYPE="foreign" FIELDS="recipientid" REFTABLE="user" REFFIELDS="id"/>
         <KEY NAME="fk_issuerid" TYPE="foreign" FIELDS="issuerid" REFTABLE="user" REFFIELDS="id"/>
         <KEY NAME="fk_issuerrole" TYPE="foreign" FIELDS="issuerrole" REFTABLE="role" REFFIELDS="id"/>
diff --git a/lib/db/upgrade.php b/lib/db/upgrade.php
index 57e29622d0c..52a0839b527 100644
--- a/lib/db/upgrade.php
+++ b/lib/db/upgrade.php
@@ -1928,7 +1928,7 @@ function xmldb_main_upgrade($oldversion) {
 
         // Adding keys to table 'badge_manual_award'.
         $table->add_key('primary', XMLDB_KEY_PRIMARY, array('id'));
-        $table->add_key('fk_badgeid', XMLDB_KEY_FOREIGN, array('id'), 'badge', array('id'));
+        $table->add_key('fk_badgeid', XMLDB_KEY_FOREIGN, array('badgeid'), 'badge', array('id'));
         $table->add_key('fk_recipientid', XMLDB_KEY_FOREIGN, array('recipientid'), 'user', array('id'));
         $table->add_key('fk_issuerid', XMLDB_KEY_FOREIGN, array('issuerid'), 'user', array('id'));
         $table->add_key('fk_issuerrole', XMLDB_KEY_FOREIGN, array('issuerrole'), 'role', array('id'));