From 97a8edddf03877cae4f1529eb56128d240af06fe Mon Sep 17 00:00:00 2001
From: Frederic Massart <fred@moodle.com>
Date: Thu, 1 Nov 2012 11:49:31 +0800
Subject: [PATCH] MDL-27901 navigation: Notice when an admin node name is
 already used

---
 lib/adminlib.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/adminlib.php b/lib/adminlib.php
index ba9a666c656..999588ca725 100644
--- a/lib/adminlib.php
+++ b/lib/adminlib.php
@@ -929,6 +929,11 @@ class admin_category implements parentable_part_of_admin_tree {
                 debugging('error - parts of tree can be inserted only into parentable parts');
                 return false;
             }
+            if (debugging('', DEBUG_DEVELOPER) && !is_null($this->locate($something->name))) {
+                // The name of the node is already used, simply warn the developer that this should not happen.
+                // It is intentional to check for the debug level before performing the check.
+                debugging('Duplicate admin page name: ' . $something->name, DEBUG_DEVELOPER);
+            }
             $parent->children[] = $something;
             if (is_array($this->category_cache) and ($something instanceof admin_category)) {
                 if (isset($this->category_cache[$something->name])) {