From 879c7655f255f07856bb8fb1065c2eb6cb933653 Mon Sep 17 00:00:00 2001 From: Dan Poltawski Date: Wed, 5 Sep 2012 10:34:51 +0800 Subject: [PATCH] MDL-35257 lib: if $CFG->logguests is disabled, avoid some log actions This is for performance, else there can be great contention on the guest user record as we've seen on moodle.org. --- lib/datalib.php | 5 +++++ lib/moodlelib.php | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/lib/datalib.php b/lib/datalib.php index 7d4512c0e01..526b16e4ffa 100644 --- a/lib/datalib.php +++ b/lib/datalib.php @@ -1762,6 +1762,11 @@ function user_accesstime_log($courseid=0) { return; } + if (isguestuser()) { + // Do not update guest access times/ips for performance. + return; + } + if (empty($courseid)) { $courseid = SITEID; } diff --git a/lib/moodlelib.php b/lib/moodlelib.php index 752465ce324..05721fd2434 100644 --- a/lib/moodlelib.php +++ b/lib/moodlelib.php @@ -3201,6 +3201,11 @@ function get_user_key($script, $userid, $instance=null, $iprestriction=null, $va function update_user_login_times() { global $USER, $DB; + if (isguestuser()) { + // Do not update guest access times/ips for performance. + return true; + } + $now = time(); $user = new stdClass();