diff --git a/admin/settings/plugins.php b/admin/settings/plugins.php
index 14050729da3..7ff697de226 100644
--- a/admin/settings/plugins.php
+++ b/admin/settings/plugins.php
@@ -330,6 +330,7 @@ if ($hassiteconfig) {
$ADMIN->add('webservicesettings', new admin_externalpage('externalservice', get_string('externalservice', 'webservice'), "$CFG->wwwroot/$CFG->admin/webservice/service.php", 'moodle/site:config', true));
$ADMIN->add('webservicesettings', new admin_externalpage('externalservicefunctions', get_string('externalservicefunctions', 'webservice'), "$CFG->wwwroot/$CFG->admin/webservice/service_functions.php", 'moodle/site:config', true));
$ADMIN->add('webservicesettings', new admin_externalpage('externalserviceusers', get_string('externalserviceusers', 'webservice'), "$CFG->wwwroot/$CFG->admin/webservice/service_users.php", 'moodle/site:config', true));
+ $ADMIN->add('webservicesettings', new admin_externalpage('externalserviceusersettings', get_string('serviceusersettings', 'webservice'), "$CFG->wwwroot/$CFG->admin/webservice/service_user_settings.php", 'moodle/site:config', true));
/// manage protocol page link
$temp = new admin_settingpage('webserviceprotocols', get_string('manageprotocols', 'webservice'));
$temp->add(new admin_setting_managewebserviceprotocols());
diff --git a/admin/webservice/forms.php b/admin/webservice/forms.php
index 2c77dd6c34a..9f26ce9a6fc 100644
--- a/admin/webservice/forms.php
+++ b/admin/webservice/forms.php
@@ -25,6 +25,32 @@
require_once $CFG->libdir.'/formslib.php';
+/**
+ * Display the authorised user settings form
+ * Including IP Restriction, Valid until and (TODO) capability
+ */
+class external_service_authorised_user_settings_form extends moodleform {
+ function definition() {
+ global $CFG, $USER, $DB;
+
+ $mform = $this->_form;
+ $data = $this->_customdata;
+
+ $mform->addElement('header', 'serviceusersettings', get_string('serviceusersettings', 'webservice'));
+
+ $mform->addElement('text', 'iprestriction', get_string('iprestriction', 'webservice'));
+ $mform->addHelpButton('iprestriction', 'iprestriction', 'webservice');
+
+ $mform->addElement('date_selector', 'validuntil', get_string('validuntil', 'webservice'), array('optional'=>true));
+ $mform->addHelpButton('validuntil', 'validuntil', 'webservice');
+
+ $this->add_action_buttons(true, get_string('updateusersettings', 'webservice'));
+
+ $this->set_data($data);
+ }
+}
+
+
class external_service_form extends moodleform {
function definition() {
global $CFG, $USER;
diff --git a/admin/webservice/script.js b/admin/webservice/script.js
deleted file mode 100644
index a7d9f7a2f1c..00000000000
--- a/admin/webservice/script.js
+++ /dev/null
@@ -1,13 +0,0 @@
-
-/* This function disable the valid until field of a user into service_users.php*/
-function external_disablevaliduntil(event, userid) {
- var disabled;
- if (document.getElementById('enablevaliduntil'+userid).checked) {
- disabled = false;
- } else {
- disabled = true;
- }
- document.getElementById('menufromday'+userid).disabled = disabled;
- document.getElementById('menufromyear'+userid).disabled = disabled;
- document.getElementById('menufrommonth'+userid).disabled = disabled;
-}
\ No newline at end of file
diff --git a/admin/webservice/service_user_settings.php b/admin/webservice/service_user_settings.php
new file mode 100644
index 00000000000..f6aacd9bbf0
--- /dev/null
+++ b/admin/webservice/service_user_settings.php
@@ -0,0 +1,84 @@
+.
+
+/**
+ * Web services user settings UI
+ *
+ * @package webservice
+ * @copyright 2009 Moodle Pty Ltd (http://moodle.com)
+ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+require_once('../../config.php');
+require_once($CFG->libdir . '/adminlib.php');
+require_once($CFG->dirroot . '/webservice/lib.php');
+require_once($CFG->dirroot . '/admin/webservice/forms.php');
+
+
+$serviceid = required_param('serviceid', PARAM_INT);
+$userid = required_param('userid', PARAM_INT);
+
+$PAGE->set_url('/admin/webservice/service_user_settings.php', array('id' => $serviceid, 'userid' => $userid));
+$PAGE->navbar->ignore_active(true);
+$PAGE->navbar->add(get_string('administrationsite'));
+$PAGE->navbar->add(get_string('plugins', 'admin'));
+$PAGE->navbar->add(get_string('webservices', 'webservice'));
+$PAGE->navbar->add(get_string('externalservices', 'webservice'),
+ new moodle_url('/admin/settings.php?section=externalservices'));
+$PAGE->navbar->add(get_string('serviceusers', 'webservice'),
+ new moodle_url('/admin/webservice/service_users.php', array('id' => $serviceid)));
+$PAGE->navbar->add(get_string('serviceusersettings', 'webservice'));
+
+//$PAGE->requires->js('/admin/webservice/script.js');
+
+admin_externalpage_setup('externalserviceusersettings');
+
+$formaction = new moodle_url('', array('id' => $serviceid, 'userid' => $userid));
+$returnurl = new moodle_url('/admin/webservice/service_users.php', array('id' => $serviceid));
+
+$webservicemanager = new webservice();
+$serviceuser = $webservicemanager->get_ws_authorised_user($serviceid, $userid);
+$usersettingsform = new external_service_authorised_user_settings_form($formaction, $serviceuser);
+$settingsformdata = $usersettingsform->get_data();
+
+if ($usersettingsform->is_cancelled()) {
+ redirect($returnurl);
+
+} else if (!empty($settingsformdata) and confirm_sesskey()) {
+ /// save user settings (administrator clicked on update button)
+ $settingsformdata = (object)$settingsformdata;
+
+ $serviceuserinfo = new stdClass();
+ $serviceuserinfo->id = $serviceuser->serviceuserid;
+ $serviceuserinfo->iprestriction = $settingsformdata->iprestriction;
+ $serviceuserinfo->validuntil = $settingsformdata->validuntil;
+
+ $webservicemanager->update_ws_authorised_user($serviceuserinfo);
+
+ //TODO: assign capability
+
+ //display successful notification
+ $notification = $OUTPUT->notification(get_string('usersettingssaved', 'webservice'), 'success');
+}
+
+echo $OUTPUT->header();
+echo $OUTPUT->heading(get_string('serviceusersettings', 'webservice'), 3, 'main');
+if (!empty($notification)) {
+ echo $notification;
+}
+$usersettingsform->display();
+
+echo $OUTPUT->footer();
diff --git a/admin/webservice/service_users.php b/admin/webservice/service_users.php
index ce6cee2f51a..c9974db946c 100644
--- a/admin/webservice/service_users.php
+++ b/admin/webservice/service_users.php
@@ -16,187 +16,88 @@
// along with Moodle. If not, see .
/**
- * Web services function UI
+ * Web services services UI
*
* @package webservice
* @copyright 2009 Moodle Pty Ltd (http://moodle.com)
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
-
require_once('../../config.php');
-require_once($CFG->libdir.'/adminlib.php');
-require_once($CFG->dirroot.'/admin/webservice/lib.php');
+require_once($CFG->libdir . '/adminlib.php');
+require_once($CFG->dirroot . '/admin/webservice/lib.php');
+require_once($CFG->dirroot . '/webservice/lib.php');
$id = required_param('id', PARAM_INT);
-$PAGE->set_url('/admin/webservice/service_users.php', array('id'=>$id));
+$PAGE->set_url('/admin/webservice/service_users.php', array('id' => $id));
$PAGE->navbar->ignore_active(true);
$PAGE->navbar->add(get_string('administrationsite'));
$PAGE->navbar->add(get_string('plugins', 'admin'));
$PAGE->navbar->add(get_string('webservices', 'webservice'));
-$PAGE->navbar->add(get_string('externalservices', 'webservice'), new moodle_url('/admin/settings.php?section=externalservices'));
+$PAGE->navbar->add(get_string('externalservices', 'webservice'),
+ new moodle_url('/admin/settings.php?section=externalservices'));
$PAGE->navbar->add(get_string('serviceusers', 'webservice'));
-$PAGE->requires->js('/admin/webservice/script.js');
-
admin_externalpage_setup('externalserviceusers');
-echo $OUTPUT->header();
+$webservicemanager = new webservice();
/// Get the user_selector we will need.
-$potentialuserselector = new service_user_selector('addselect', array('serviceid' => $id, 'displayallowedusers' => 0));
-$alloweduserselector = new service_user_selector('removeselect', array('serviceid' => $id, 'displayallowedusers' => 1));
+$potentialuserselector = new service_user_selector('addselect',
+ array('serviceid' => $id, 'displayallowedusers' => 0));
+$alloweduserselector = new service_user_selector('removeselect',
+ array('serviceid' => $id, 'displayallowedusers' => 1));
/// Process incoming user assignments to the service
- if (optional_param('add', false, PARAM_BOOL) && confirm_sesskey()) {
- $userstoassign = $potentialuserselector->get_selected_users();
- if (!empty($userstoassign)) {
-
- foreach ($userstoassign as $adduser) {
- $serviceuser = new object();
- $serviceuser->externalserviceid = $id;
- $serviceuser->userid = $adduser->id;
- $serviceuser->timecreated = mktime();
- $DB->insert_record('external_services_users', $serviceuser);
- add_to_log(1, 'core', 'assign', $CFG->admin.'/webservice/service_users.php?id='.$id, 'add', '', $adduser->id);
- }
-
- $potentialuserselector->invalidate_selected_users();
- $alloweduserselector->invalidate_selected_users();
- }
+if (optional_param('add', false, PARAM_BOOL) && confirm_sesskey()) {
+ $userstoassign = $potentialuserselector->get_selected_users();
+ if (!empty($userstoassign)) {
+ foreach ($userstoassign as $adduser) {
+ $serviceuser = new object();
+ $serviceuser->externalserviceid = $id;
+ $serviceuser->userid = $adduser->id;
+ $webservicemanager->add_ws_authorised_user($serviceuser);
+ add_to_log(1, 'core', 'assign', $CFG->admin . '/webservice/service_users.php?id='
+ . $id, 'add', '', $adduser->id);
}
+ $potentialuserselector->invalidate_selected_users();
+ $alloweduserselector->invalidate_selected_users();
+ }
+}
/// Process removing user assignments to the service
- if (optional_param('remove', false, PARAM_BOOL) && confirm_sesskey()) {
- $userstoremove = $alloweduserselector->get_selected_users();
- if (!empty($userstoremove)) {
-
- foreach ($userstoremove as $removeuser) {
- $DB->delete_records('external_services_users', array('externalserviceid' => $id, 'userid' => $removeuser->id));
- add_to_log(1, 'core', 'assign', $CFG->admin.'/webservice/service_users.php?id='.$id, 'remove', '', $removeuser->id);
- }
-
- $potentialuserselector->invalidate_selected_users();
- $alloweduserselector->invalidate_selected_users();
- }
+if (optional_param('remove', false, PARAM_BOOL) && confirm_sesskey()) {
+ $userstoremove = $alloweduserselector->get_selected_users();
+ if (!empty($userstoremove)) {
+ foreach ($userstoremove as $removeuser) {
+ $webservicemanager->remove_ws_authorised_user($removeuser, $id);
+ add_to_log(1, 'core', 'assign', $CFG->admin . '/webservice/service_users.php?id='
+ . $id, 'remove', '', $removeuser->id);
}
+ $potentialuserselector->invalidate_selected_users();
+ $alloweduserselector->invalidate_selected_users();
+ }
+}
/// Print the form.
/// display the UI
-?>
-
-
-id = $serviceuserid;
- if ($enablevaliduntil) {
- $serviceuser->validuntil = $validuntil;
- } else {
- $serviceuser->validuntil = null; //the valid until field is disabled, we reset the value
- }
- $serviceuser->iprestriction = $iprestriction;
- $DB->update_record('external_services_users', $serviceuser);
-
- //TODO: assign capability
-}
+echo $OUTPUT->heading(get_string('selectauthorisedusers', 'webservice'), 3, 'main');
+$selectoroptions = new stdClass();
+$selectoroptions->serviceid = $id;
+$selectoroptions->alloweduserselector = $alloweduserselector;
+$selectoroptions->potentialuserselector = $potentialuserselector;
+echo $renderer->admin_authorised_user_selector($selectoroptions);
//display the list of allowed users with their options (ip/timecreated / validuntil...)
//check that the user has the service required capability (if needed)
-$sql = " SELECT u.id as id, esu.id as serviceuserid, u.email as email, u.firstname as firstname, u.lastname as lastname,
- esu.iprestriction as iprestriction, esu.validuntil as validuntil,
- esu.timecreated as timecreated
- FROM {user} u, {external_services_users} esu
- WHERE username <> 'guest' AND deleted = 0 AND confirmed = 1
- AND esu.userid = u.id
- AND esu.externalserviceid = ?";
-$allowedusers = $DB->get_records_sql($sql, array($id));
+$allowedusers = $webservicemanager->get_ws_authorised_users($id);
if (!empty($allowedusers)) {
- echo $OUTPUT->box_start('generalbox', 'alloweduserlist');
-
- echo "";
- echo "
"; //reduce font of the user settings
- foreach($allowedusers as $user) {
-
- echo print_collapsible_region_start('', 'usersettings'.$user->id,$user->firstname." ".$user->lastname.", ".$user->email,false,true,true);
-
- //user settings form
- $contents = "
";
- // the following date selector needs to have specific day/month/year field ids because we use javascript (enable/disable).
- $contents .= html_writer::select_time('days', 'fromday'.$user->id, $user->validuntil);
- $contents .= html_writer::select_time('months', 'frommonth'.$user->id, $user->validuntil);
- $contents .= html_writer::select_time('years', 'fromyear'.$user->id, $user->validuntil);;
- $contents .= html_writer::checkbox('enablevaliduntil', 1, !empty($user->validuntil), get_string('enabled', 'webservice'), array('id'=>'enablevaliduntil'.$user->id));
- // TODO: init date selector using standard $PAGE->requires->js_init_call();
-
- $contents .= "