L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-17135 reverting recent change in service management UI - since 1.7 the right way is to use formslib instead of hand written forms (which is roughly equiwalent to new outputlib stuff, sorry); this also fixes regression which incorrectly allowed editting of built-in services

Browse Source
This commit is contained in:
skodak
2009-10-21 19:36:39 +00:00
parent f0dafb3c85
commit 86c252b47d
5 changed files with 99 additions and 221 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/adminlib.php
+7 -6
View File
@@ -6161,13 +6161,14 @@ class admin_setting_manageexternalservices extends admin_setting {
$stradd = get_string('add');
$strfunctions = get_string('functions', 'webservice');
$strusers = get_string('restrictedusers', 'webservice');
$strserviceusers = get_string('serviceusers', 'webservice');
$esurl = "$CFG->wwwroot/$CFG->admin/external_service.php";
$efurl = "$CFG->wwwroot/$CFG->admin/external_service_functions.php";
$euurl = "$CFG->wwwroot/$CFG->admin/external_service_users.php";
// built in services
$return = $OUTPUT->heading(get_string('servicesbuiltin', 'webservice'), 3, 'main', true);
$return = $OUTPUT->heading(get_string('servicesbuiltin', 'webservice'), 3, 'main');
$services = $DB->get_records_select('external_services', 'component IS NOT NULL', null, 'name');
@@ -6194,9 +6195,9 @@ class admin_setting_manageexternalservices extends admin_setting {
$functions = "<a href=\"$efurl?id=$service->id\">$strfunctions</a>";
if ($service->restrictedusers) {
$users = "<a href=\"$euurl?id=$service->id\">$strusers</a>";
$users = "<a href=\"$euurl?id=$service->id\">$strserviceusers</a>";
} else {
$users = get_string('nouserrestriction','webservice');
$users = '-';
}
$edit = "<a href=\"$esurl?id=$service->id\">$stredit</a>";
@@ -6207,7 +6208,7 @@ class admin_setting_manageexternalservices extends admin_setting {
$return .= $OUTPUT->table($table);
// Custom services
$return .= $OUTPUT->heading(get_string('servicescustom', 'webservice'), 3, 'main', true);
$return .= $OUTPUT->heading(get_string('servicescustom', 'webservice'), 3, 'main');
$services = $DB->get_records_select('external_services', 'component IS NULL', null, 'name');
$table = new html_table();
@@ -6234,9 +6235,9 @@ class admin_setting_manageexternalservices extends admin_setting {
$functions = "<a href=\"$efurl?id=$service->id\">$strfunctions</a>";
if ($service->restrictedusers) {
$users = "<a href=\"$euurl?id=$service->id\">$strusers</a>";
$users = "<a href=\"$euurl?id=$service->id\">$strserviceusers</a>";
} else {
$users = get_string('nouserrestriction','webservice');
$users = '-';
}
$edit = "<a href=\"$esurl?id=$service->id\">$stredit</a>";