From 31a9b403ca58febc6256d9c069665d0e2fd5e5fb Mon Sep 17 00:00:00 2001 From: Matt Davidson Date: Mon, 12 Dec 2016 08:18:17 -0500 Subject: [PATCH] MDL-56810 unoconv: task fails if user removed If the user is removed from a course after a submission has been made, the task will crash and never continue. This removes submissions from the cron task if the user isn't enrolled in the course. --- .../classes/task/convert_submissions.php | 20 +++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/mod/assign/feedback/editpdf/classes/task/convert_submissions.php b/mod/assign/feedback/editpdf/classes/task/convert_submissions.php index 9c5505db1c1..6662e51ba04 100644 --- a/mod/assign/feedback/editpdf/classes/task/convert_submissions.php +++ b/mod/assign/feedback/editpdf/classes/task/convert_submissions.php @@ -92,14 +92,18 @@ class convert_submissions extends scheduled_task { mtrace('Convert ' . count($users) . ' submission attempt(s) for assignment ' . $assignmentid); foreach ($users as $userid) { - document_services::get_page_images_for_attempt($assignment, - $userid, - $attemptnumber, - true); - document_services::get_page_images_for_attempt($assignment, - $userid, - $attemptnumber, - false); + try { + document_services::get_page_images_for_attempt($assignment, + $userid, + $attemptnumber, + true); + document_services::get_page_images_for_attempt($assignment, + $userid, + $attemptnumber, + false); + } catch (\moodle_exception $e) { + mtrace('Conversion failed with error:' . $e->errorcode); + } } $DB->delete_records('assignfeedback_editpdf_queue', array('id' => $record->id));