From 82fc915f0803c85bfa6ffd57c87f953065a0d9cf Mon Sep 17 00:00:00 2001 From: Juan Leyva Date: Thu, 16 Apr 2015 10:22:59 +0200 Subject: [PATCH] MDL-45131 grades: Add validation for returned parameters in WS tests --- grade/report/user/tests/externallib_test.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/grade/report/user/tests/externallib_test.php b/grade/report/user/tests/externallib_test.php index 90223901a32..2c04c2058d0 100644 --- a/grade/report/user/tests/externallib_test.php +++ b/grade/report/user/tests/externallib_test.php @@ -177,7 +177,8 @@ class gradereport_user_externallib_testcase extends externallib_advanced_testcas $sink = $this->redirectEvents(); $this->setUser($student1); - gradereport_user_external::view_grade_report($course->id); + $result = gradereport_user_external::view_grade_report($course->id); + $result = external_api::clean_returnvalue(gradereport_user_external::view_grade_report_returns(), $result); $events = $sink->get_events(); $this->assertCount(1, $events); $event = reset($events); @@ -188,7 +189,8 @@ class gradereport_user_externallib_testcase extends externallib_advanced_testcas $this->assertEquals($USER->id, $event->get_data()['relateduserid']); $this->setUser($teacher); - gradereport_user_external::view_grade_report($course->id, $student1->id); + $result = gradereport_user_external::view_grade_report($course->id, $student1->id); + $result = external_api::clean_returnvalue(gradereport_user_external::view_grade_report_returns(), $result); $events = $sink->get_events(); $event = reset($events); $sink->close();