From 8039c068003ded358b1a9df7710e1653ebfdf082 Mon Sep 17 00:00:00 2001
From: Michael Milette <michael.milette@tngconsulting.ca>
Date: Wed, 12 Feb 2020 10:37:25 -0500
Subject: [PATCH] MDL-66849 output: Remove custom menu title when not specified

---
 lib/outputcomponents.php                | 9 ++++-----
 lib/templates/custom_menu_item.mustache | 2 +-
 lib/tests/outputcomponents_test.php     | 2 +-
 3 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/lib/outputcomponents.php b/lib/outputcomponents.php
index 6675c831c71..f42617f845e 100644
--- a/lib/outputcomponents.php
+++ b/lib/outputcomponents.php
@@ -3733,11 +3733,10 @@ class custom_menu extends custom_menu_item {
                 $setting = trim($setting);
                 if (!empty($setting)) {
                     switch ($i) {
-                        case 0:
+                        case 0: // Menu text.
                             $itemtext = ltrim($setting, '-');
-                            $itemtitle = $itemtext;
                             break;
-                        case 1:
+                        case 1: // URL.
                             try {
                                 $itemurl = new moodle_url($setting);
                             } catch (moodle_exception $exception) {
@@ -3746,10 +3745,10 @@ class custom_menu extends custom_menu_item {
                                 $itemurl = null;
                             }
                             break;
-                        case 2:
+                        case 2: // Title attribute.
                             $itemtitle = $setting;
                             break;
-                        case 3:
+                        case 3: // Language.
                             if (!empty($language)) {
                                 $itemlanguages = array_map('trim', explode(',', $setting));
                                 $itemvisible &= in_array($language, $itemlanguages);
diff --git a/lib/templates/custom_menu_item.mustache b/lib/templates/custom_menu_item.mustache
index 9bcc29e753e..d353dcc69c3 100644
--- a/lib/templates/custom_menu_item.mustache
+++ b/lib/templates/custom_menu_item.mustache
@@ -1,7 +1,7 @@
 {{^divider}}
 {{#haschildren}}
 <li class="dropdown nav-item">
-    <a class="dropdown-toggle nav-link" id="drop-down-{{uniqid}}" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" href="#" aria-controls="drop-down-menu-{{uniqid}}">
+    <a class="dropdown-toggle nav-link" id="drop-down-{{uniqid}}" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false" href="#" {{#title}}title="{{{title}}}"{{/title}} aria-controls="drop-down-menu-{{uniqid}}">
         {{{text}}}
     </a>
     <div class="dropdown-menu" role="menu" id="drop-down-menu-{{uniqid}}" aria-labelledby="drop-down-{{uniqid}}">
diff --git a/lib/tests/outputcomponents_test.php b/lib/tests/outputcomponents_test.php
index 958a70b9e69..d2fbda46fec 100644
--- a/lib/tests/outputcomponents_test.php
+++ b/lib/tests/outputcomponents_test.php
@@ -326,7 +326,7 @@ EOF;
         $itemurl = $item->get_url();
         $this->assertTrue($itemurl instanceof moodle_url);
         $this->assertEquals('http://moodle.org', $itemurl->out());
-        $this->assertEquals($item->get_text(), $item->get_title()); // Implicit title.
+        $this->assertNull($item->get_title()); // Implicit title.
 
         /** @var custom_menu_item $item */
         $item = array_shift($firstlevel);