diff --git a/admin/mnet/mnet_themes.php b/admin/mnet/mnet_themes.php
index 96028a5042c..178485a9d79 100644
--- a/admin/mnet/mnet_themes.php
+++ b/admin/mnet/mnet_themes.php
@@ -52,7 +52,9 @@
if (confirm_sesskey()) {
if ($choose == $unlikely_name) {
$mnet_peer->force_theme = 1;
+ $mnet_peer->updateparams->force_theme = 1;
$mnet_peer->theme = '';
+ $mnet_peer->updateparams->theme = '';
if ($mnet_peer->commit()) {
$report = array(get_string('themesaved'), 'informationbox');
} else {
@@ -63,7 +65,8 @@
$report = array('This theme is not installed!'.'3', 'errorbox');
} else {
$mnet_peer->force_theme = 1;
- $mnet_peer->theme = addslashes($choose);
+ $mnet_peer->theme = $choose;
+ $mnet_peer->updateparams->theme = addslashes($choose);
if ($mnet_peer->commit()) {
$report = array(get_string('themesaved').'1', 'informationbox');
} else {
diff --git a/admin/mnet/peers.php b/admin/mnet/peers.php
index d816613171e..dac842479eb 100644
--- a/admin/mnet/peers.php
+++ b/admin/mnet/peers.php
@@ -97,6 +97,7 @@ if (($form = data_submitted()) && confirm_sesskey()) {
}
if (isset($form->deleted) && ($form->deleted == '0' || $form->deleted == '1')) {
+ $mnet_peer->updateparams->deleted = $form->deleted;
$mnet_peer->deleted = $form->deleted;
}
@@ -108,9 +109,10 @@ if (($form = data_submitted()) && confirm_sesskey()) {
} else {
$oldkey = $mnet_peer->public_key;
$mnet_peer->public_key = $form->public_key;
- $mnet_peer->public_key_expires = $mnet_peer->check_common_name($form->public_key);
+ $mnet_peer->updateparams->public_key = addslashes($form->public_key);
+ $mnet_peer->public_key_expires = $mnet_peer->check_common_name($form->public_key);
+ $mnet_peer->updateparams->public_key_expires = $mnet_peer->check_common_name($form->public_key);
if ($mnet_peer->public_key_expires == false) {
- $mnet_peer->public_key == $oldkey;
$errmsg = '
';
foreach ($mnet_peer->error as $err) {
$errmsg .= $err['code'] . ': ' . $err['text'].'
';
diff --git a/mnet/peer.php b/mnet/peer.php
index 46cf2808cd1..a5a5d591f64 100644
--- a/mnet/peer.php
+++ b/mnet/peer.php
@@ -10,6 +10,8 @@
class mnet_peer {
+ //Unless stated otherwise, properties of this object are unescaped, and unsafe to
+ //insert into the db without further processing.
var $id = 0;
var $wwwroot = '';
var $ip_address = '';
@@ -23,8 +25,12 @@ class mnet_peer {
var $applicationid = 1; // Default of 1 == Moodle
var $keypair = array();
var $error = array();
+ //Object whose properties need to be put into the database:
+ //(properties here are slashescaped)
+ var $updateparams;
function mnet_peer() {
+ $this->updateparams = new stdClass();
return true;
}
@@ -47,7 +53,8 @@ class mnet_peer {
return false;
}
- $this->name = $wwwroot;
+ $this->name = stripslashes($wwwroot);
+ $this->updateparams->name = $wwwroot;
// TODO: In reality, this will be prohibitively slow... need another
// default - maybe blank string
@@ -56,12 +63,16 @@ class mnet_peer {
$count = preg_match("@