From 7fa7d4dd2a85dc6f02b0c8ce8cf7ae248964af03 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Sat, 21 Jan 2023 18:18:21 +0100 Subject: [PATCH] MDL-76362 workshop: check for empty (null included) feedbackreviewer As far as feedbackreviewer can be null, we cannot, since PHP 8.1 apply any string operation (trim, strlen...) on it, hence, checking before applying. --- mod/workshop/renderer.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/workshop/renderer.php b/mod/workshop/renderer.php index bb9f230b6e0..e2b3c58f271 100644 --- a/mod/workshop/renderer.php +++ b/mod/workshop/renderer.php @@ -1841,7 +1841,7 @@ class mod_workshop_renderer extends plugin_renderer_base { $output .= $this->render($workshop->prepare_submission_summary($submission, $shownames)); $output .= $this->box_end(); - if (strlen(trim($assessment->feedbackreviewer)) > 0) { + if (!empty($assessment->feedbackreviewer) && strlen(trim($assessment->feedbackreviewer)) > 0) { $output .= $this->render(new workshop_feedback_reviewer($assessment)); } }