From 7efc2aeabaeaf101ec0d4a6ef6be32f74a559c69 Mon Sep 17 00:00:00 2001 From: Sara Arjona Date: Fri, 14 May 2021 15:57:54 +0200 Subject: [PATCH] MDL-71157 block_myoverview: remove wait from behat The step "And I wait until ".block_myoverview [data-control='next']" "css_element" exists" is not correct because this [data-control='next'] element exists before and after the step so, in some cases, it might cause the following step will start earlier than expected. As pending JS has been added, this wait steps are not required any more. --- .../myoverview/tests/behat/block_myoverview_pagination.feature | 2 -- 1 file changed, 2 deletions(-) diff --git a/blocks/myoverview/tests/behat/block_myoverview_pagination.feature b/blocks/myoverview/tests/behat/block_myoverview_pagination.feature index 97922524079..b3a6b514f47 100644 --- a/blocks/myoverview/tests/behat/block_myoverview_pagination.feature +++ b/blocks/myoverview/tests/behat/block_myoverview_pagination.feature @@ -147,7 +147,6 @@ Feature: My overview block pagination | student1 | C13 | student | When I log in as "student1" And I click on "[data-control='next']" "css_element" in the "Course overview" "block" - And I wait until ".block_myoverview [data-control='next']" "css_element" exists Then the "class" attribute of ".block_myoverview [data-control='next']" "css_element" should contain "disabled" And I log out @@ -181,7 +180,6 @@ Feature: My overview block pagination | student1 | C25 | student | When I log in as "student1" And I click on "[data-control='next']" "css_element" in the "Course overview" "block" - And I wait until ".block_myoverview [data-control='next']" "css_element" exists Then the "class" attribute of ".block_myoverview [data-control='next']" "css_element" should not contain "disabled" And the "class" attribute of ".block_myoverview [data-control='previous']" "css_element" should not contain "disabled" And I should see "Course 13" in the "Course overview" "block"