From fede879cf238e919776cb351dd0f1b42a8ce1da0 Mon Sep 17 00:00:00 2001 From: Frederic Massart Date: Thu, 13 Sep 2012 16:51:45 +0800 Subject: [PATCH] MDL-31499 Javascript: Handle invalid window names in openpopup --- lib/javascript-static.js | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/lib/javascript-static.js b/lib/javascript-static.js index 812fe07c7fa..068fb988c42 100644 --- a/lib/javascript-static.js +++ b/lib/javascript-static.js @@ -1178,6 +1178,15 @@ function openpopup(event, args) { } } + // Cleans window name because IE does not support funky ones. + var nameregex = /[^a-z0-9_]/i; + if (args.name.match(nameregex)) { + args.name = args.name.replace(nameregex, '_'); + if (M.cfg.developerdebug) { + alert('DEVELOPER NOTICE: Invalid \'name\' passed to openpopup()'); + } + } + var fullurl = args.url; if (!args.url.match(/https?:\/\//)) { fullurl = M.cfg.wwwroot + args.url;